Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RUMF-807] Export types used in API #662

Merged
merged 2 commits into from
Dec 29, 2020
Merged

[RUMF-807] Export types used in API #662

merged 2 commits into from
Dec 29, 2020

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Dec 22, 2020

Motivation

fix #654

Changes

Add in exports:

  • rum: ProvidedSource
  • logs: StatusType, HandlerType

Testing

N/A

I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner December 22, 2020 09:57
webNeat
webNeat approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@webNeat webNeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aleksandrlat
aleksandrlat approved these changes Dec 28, 2020
View reviewed changes
Copy link

@aleksandrlat aleksandrlat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bcaudan!

@codecov-io
Copy link

Codecov Report

Merging #662 (9937b54) into master (68a4381) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #662      +/-   ##
==========================================
- Coverage   87.75%   87.71%   -0.04%     
==========================================
  Files          55       55              
  Lines        2531     2531              
  Branches      524      524              
==========================================
- Hits         2221     2220       -1     
- Misses        310      311       +1
Impacted Files Coverage Δ
packages/rum/src/transport/batch.ts 76.31% <0.00%> (-2.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68a4381...9937b54. Read the comment docs.

@BenoitZugmeyer BenoitZugmeyer merged commit c645bf8 into master Dec 29, 2020
@BenoitZugmeyer BenoitZugmeyer mentioned this pull request Dec 29, 2020
Closed
@BenoitZugmeyer BenoitZugmeyer deleted the bcaudan/export-types branch January 15, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webNeat webNeat webNeat approved these changes

@aleksandrlat aleksandrlat aleksandrlat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return typescript types back
5 participants
@bcaudan @codecov-io @webNeat @aleksandrlat @BenoitZugmeyer