Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUMF-727] introduce v2 format #570

Merged
merged 6 commits into from
Oct 19, 2020
Merged

✨ [RUMF-727] introduce v2 format #570

merged 6 commits into from
Oct 19, 2020

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Oct 16, 2020

Motivation

Start using v2 format and introduce format validation

Changes

  • Introduce v2_format feature flag
  • Duplicate types for V2
  • Use dedicated events for v2
  • Add validation for v2 events generated in unit tests
  • Handle V2 long tasks

Testing

Automated tests


I have gone over the contributing documentation.

@codecov-io
Copy link

codecov-io commented Oct 16, 2020

Codecov Report

Merging #570 into master will decrease coverage by 0.35%.
The diff coverage is 81.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #570      +/-   ##
==========================================
- Coverage   88.47%   88.12%   -0.36%     
==========================================
  Files          42       46       +4     
  Lines        2299     2357      +58     
  Branches      479      491      +12     
==========================================
+ Hits         2034     2077      +43     
- Misses        265      280      +15     
Impacted Files Coverage Δ
packages/logs/src/logger.ts 95.91% <ø> (ø)
packages/rum/src/assembly.ts 100.00% <ø> (ø)
packages/rum/src/rum.entry.ts 94.00% <ø> (ø)
packages/rum/src/parentContexts.ts 85.29% <16.66%> (-14.71%) ⬇️
packages/rum/src/batch.ts 73.17% <20.00%> (-7.39%) ⬇️
packages/rum/test/formatValidation.ts 83.33% <83.33%> (ø)
packages/rum/src/resourceUtils.ts 97.26% <90.00%> (ø)
packages/core/src/errorCollection.ts 89.28% <100.00%> (ø)
packages/core/src/utils.ts 88.14% <100.00%> (ø)
packages/rum/src/assemblyV2.ts 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdc657d...b47128a. Read the comment docs.

@bcaudan bcaudan force-pushed the bcaudan/v2-format branch 2 times, most recently from b47128a to dfdc516 Compare October 16, 2020 15:28
@bcaudan bcaudan marked this pull request as ready for review October 16, 2020 15:40
@bcaudan bcaudan requested a review from a team as a code owner October 16, 2020 15:40
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! I think it would have been better to rename V1 functions/types/events to add v1 in their name, instead of adding new ones with v2 (like I did on web-ui). This way, the migration cleanup would be easier. But that's fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants