-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [RUMF-727] introduce v2 format #570
Conversation
d20a2eb
to
527bf55
Compare
Codecov Report
@@ Coverage Diff @@
## master #570 +/- ##
==========================================
- Coverage 88.47% 88.12% -0.36%
==========================================
Files 42 46 +4
Lines 2299 2357 +58
Branches 479 491 +12
==========================================
+ Hits 2034 2077 +43
- Misses 265 280 +15
Continue to review full report at Codecov.
|
b47128a
to
dfdc516
Compare
dfdc516
to
e6932e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good! I think it would have been better to rename V1 functions/types/events to add v1
in their name, instead of adding new ones with v2
(like I did on web-ui). This way, the migration cleanup would be easier. But that's fine now.
Motivation
Start using v2 format and introduce format validation
Changes
v2_format
feature flagTesting
Automated tests
I have gone over the contributing documentation.