✨ [RUMF-709][core] support 'null' as a context value #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`combine` is equivalent to `deepMerge`, but have improved typing support, so we don't need to cast it as much: it can infer that values are Context (or objects compatible with Context).
bcaudan
reviewed
Sep 25, 2020
bcaudan
reviewed
Sep 25, 2020
Codecov Report
@@ Coverage Diff @@
## master #546 +/- ##
==========================================
- Coverage 88.36% 88.11% -0.26%
==========================================
Files 36 36
Lines 2287 2288 +1
Branches 473 469 -4
==========================================
- Hits 2021 2016 -5
- Misses 266 272 +6
Continue to review full report at Codecov.
|
bcaudan
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ensure that nothing breaks when the user unexpectedly pass
nullfor values that end up in aContext.Changes
Add proper support for
nullvalue in context.Testing
Unit tests have been upgraded. You can test it manually by calling
DD_RUM.init({ service: null, clientToken: 'xxx', applicationId: 'xxx' })I have gone over the contributing documentation.