Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUMF-642] do not return internal context if the session is untracked #498

Merged
merged 2 commits into from
Aug 24, 2020

Conversation

BenoitZugmeyer
Copy link
Member

Motivation

When the session is untracked, we still create a new view object, but we don't send it to the intake. It should not be used by logs or trace because it would lead to an undefined view event.

Changes

Make sure the session have an id and is tracked before exposing the internal context

Testing


I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner August 20, 2020 15:50
Copy link
Member

@mquentin mquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@codecov-commenter
Copy link

Codecov Report

Merging #498 into master will increase coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #498      +/-   ##
==========================================
+ Coverage   87.39%   87.69%   +0.29%     
==========================================
  Files          34       34              
  Lines        2111     2113       +2     
  Branches      416      417       +1     
==========================================
+ Hits         1845     1853       +8     
+ Misses        266      260       -6     
Impacted Files Coverage Δ
packages/rum/src/rum.ts 90.83% <100.00%> (+4.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2a5f08...6bcd047. Read the comment docs.

@BenoitZugmeyer BenoitZugmeyer merged commit 48bb4a4 into master Aug 24, 2020
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/do-not-expose-untracked-view branch August 24, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants