Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [RUM] fix loading measures conversion to nanoseconds #490

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

BenoitZugmeyer
Copy link
Member

Motivation

Load timings where not converted to nanosecond anymore

Changes

Make sure load timings are converted to nanosecond

Testing


I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner August 14, 2020 09:47
@codecov-commenter
Copy link

Codecov Report

Merging #490 into master will increase coverage by 0.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #490      +/-   ##
==========================================
+ Coverage   87.40%   87.73%   +0.33%     
==========================================
  Files          34       34              
  Lines        2112     2112              
  Branches      417      417              
==========================================
+ Hits         1846     1853       +7     
+ Misses        266      259       -7     
Impacted Files Coverage Δ
packages/rum/src/rum.ts 89.92% <100.00%> (+3.87%) ⬆️
packages/logs/src/logger.ts 95.29% <0.00%> (+1.17%) ⬆️
packages/logs/src/loggerSession.ts 100.00% <0.00%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acd261e...2339c4a. Read the comment docs.

@BenoitZugmeyer BenoitZugmeyer merged commit 8707482 into master Aug 14, 2020
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/fix-measures-timings-conversion-to-ns branch August 14, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants