Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨[RUMF-430] enable new session strategy #360

Merged
merged 2 commits into from
Apr 16, 2020
Merged

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Apr 14, 2020

cf #343

  • Check page visibility every 1 minute to expand the session
  • Add a session timeout at 4h
  • Enforce the session expiration if last interaction was more than 15 minutes ago

@bcaudan bcaudan requested a review from a team as a code owner April 14, 2020 14:31
@codecov-io
Copy link

Codecov Report

Merging #360 into master will decrease coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #360      +/-   ##
==========================================
- Coverage   86.91%   86.75%   -0.16%     
==========================================
  Files          29       29              
  Lines        1689     1684       -5     
  Branches      349      344       -5     
==========================================
- Hits         1468     1461       -7     
- Misses        221      223       +2     
Impacted Files Coverage Δ
packages/core/src/sessionManagement.ts 100.00% <100.00%> (ø)
packages/logs/src/loggerSession.ts 100.00% <100.00%> (ø)
packages/rum/src/rumSession.ts 100.00% <100.00%> (ø)
packages/rum/src/rum.ts 88.42% <0.00%> (-2.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b7707...2c0a5ba. Read the comment docs.

@bcaudan bcaudan merged commit d3c2000 into master Apr 16, 2020
@bcaudan bcaudan deleted the bcaudan/enable-new-session branch April 16, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants