Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨[RUMF-435] add session type on all events #347

Merged
merged 2 commits into from
Apr 9, 2020
Merged

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Apr 8, 2020

  • user for regular session
  • synthetics for browser test sessions

@bcaudan bcaudan requested a review from a team as a code owner April 8, 2020 15:38
@codecov-io
Copy link

codecov-io commented Apr 8, 2020

Codecov Report

Merging #347 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
+ Coverage   87.25%   87.29%   +0.04%     
==========================================
  Files          29       29              
  Lines        1671     1677       +6     
  Branches      344      346       +2     
==========================================
+ Hits         1458     1464       +6     
  Misses        213      213              
Impacted Files Coverage Δ
packages/rum/src/rum.ts 86.73% <100.00%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 653bb0e...a1176d7. Read the comment docs.

- `user` for regular session
- `synthetics` for browser test sessions
@bcaudan bcaudan force-pushed the bcaudan/session-type branch from 6043938 to a1176d7 Compare April 8, 2020 16:35
@bcaudan bcaudan merged commit 0efc80a into master Apr 9, 2020
@bcaudan bcaudan deleted the bcaudan/session-type branch April 9, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants