Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [RUM-99] don't stop RUM/Replay on beforeunload #3406

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BenoitZugmeyer
Copy link
Member

Motivation

Changes

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@5a7e2f7). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3406   +/-   ##
=======================================
  Coverage        ?   92.70%           
=======================================
  Files           ?      302           
  Lines           ?     7883           
  Branches        ?     1800           
=======================================
  Hits            ?     7308           
  Misses          ?      575           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 148.44 KiB 148.41 KiB -30 B -0.02%
Logs 52.21 KiB 52.21 KiB 0 B 0.00%
Rum Slim 106.91 KiB 106.94 KiB 33 B +0.03%
Worker 24.50 KiB 24.50 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.004 0.001
addaction 0.037 0.050 0.013
addtiming 0.001 0.002 0.001
adderror 0.066 0.073 0.007
startstopsessionreplayrecording 0.009 0.019 0.010
startview 0.366 0.579 0.213
logmessage 0.022 0.032 0.010
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 30.25 KiB 27.16 KiB -3163 B
addaction 57.10 KiB 54.67 KiB -2487 B
addtiming 26.56 KiB 27.10 KiB 555 B
adderror 59.12 KiB 59.36 KiB 244 B
startstopsessionreplayrecording 29.32 KiB 25.20 KiB -4227 B
startview 427.62 KiB 433.97 KiB 6.35 KiB
logmessage 59.49 KiB 55.66 KiB -3922 B

🔗 RealWorld

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants