Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 cleanup unused Experimental Features #2996

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

BenoitZugmeyer
Copy link
Member

Motivation

Removing dead code

Changes

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner September 16, 2024 13:03
@BenoitZugmeyer
Copy link
Member Author

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Sep 16, 2024

🚂 Branch Integration: starting soon, median merge time is 13m

Commit 2091830aea will soon be integrated into staging-38.

Use /to-staging -c to cancel this operation!

dd-devflow bot added a commit that referenced this pull request Sep 16, 2024
@dd-devflow
Copy link
Contributor

dd-devflow bot commented Sep 16, 2024

🚨 Branch Integration: This merge request has conflicts

We couldn't automatically merge the commit 2091830aea into staging-38!

You can use this resolution PR: #2997 to fix the conflicts.

If you need support, contact us on Slack #devflow with those details!

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Sep 16, 2024

🚂 Branch Integration: starting soon, median merge time is 13m

Commit 2091830aea will soon be integrated into staging-38.

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Sep 16, 2024

🚂 Branch Integration

Commit 2091830aea has been merged into staging-38 in merge commit 307c91fa76.

Check out the triggered pipeline on Gitlab 🦊

Copy link

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 161.30 KiB 161.16 KiB -143 B -0.09%
Logs 56.12 KiB 56.02 KiB -98 B -0.17%
Rum Slim 109.91 KiB 109.77 KiB -143 B -0.13%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.002 0.000
addaction 0.034 0.034 -0.000
addtiming 0.001 0.001 0.000
adderror 0.032 0.034 0.002
startstopsessionreplayrecording 0.810 0.845 0.035
startview 1.117 1.153 0.037
logmessage 0.022 0.018 -0.004
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 7.71 KiB 7.87 KiB 162 B
addaction 39.51 KiB 40.01 KiB 514 B
addtiming 7.72 KiB 6.63 KiB -1115 B
adderror 44.91 KiB 44.44 KiB -476 B
startstopsessionreplayrecording 5.28 KiB 4.03 KiB -1285 B
startview 342.76 KiB 346.43 KiB 3.67 KiB
logmessage 41.11 KiB 41.26 KiB 159 B

🔗 RealWorld

@BenoitZugmeyer BenoitZugmeyer merged commit 1ef0ec2 into main Sep 16, 2024
20 checks passed
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/cleanup-unused-experimental-features branch September 16, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants