-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💥 [RUM 6075] Save anonymous id in session cookie #2985
Conversation
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v6 #2985 +/- ##
==========================================
+ Coverage 93.61% 93.63% +0.01%
==========================================
Files 279 280 +1
Lines 7473 7491 +18
Branches 1690 1702 +12
==========================================
+ Hits 6996 7014 +18
Misses 477 477 ☔ View full report in Codecov by Sentry. |
48ecdd4
to
ebbd968
Compare
1ca13a8
to
c05301e
Compare
6c2171e
to
a620dfb
Compare
Clean up imports Clean up
146ba07
to
b0d4183
Compare
!commonContext.user.anonymous_id | ||
) { | ||
const { type } = configuration.sessionStoreStrategyType ?? { type: 'LocalStorage' } | ||
commonContext.user.anonymous_id = retrieveAnonymousId(type) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💬 suggestion: a bit related to my previous comment, but we should probably be able to do something like:
commonContext.user.anonymous_id = retrieveAnonymousId(type) | |
commonContext.user.anonymous_id = session.getAnonymousUserId() |
4462574
to
66e5138
Compare
Motivation
Test saving anonymous id in session cookie on org2.
Changes
Add anonymous id to session cookie behind a feature flag.
Testing
I have gone over the contributing documentation.