🐛 Fix LCP with size < previous LCP #2586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaudan
approved these changes
Feb 2, 2024
packages/rum-core/src/domain/view/viewMetrics/trackLargestContentfulPaint.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/view/viewMetrics/trackLargestContentfulPaint.spec.ts
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2586 +/- ##
=======================================
Coverage 92.78% 92.78%
=======================================
Files 235 235
Lines 6789 6792 +3
Branches 1487 1488 +1
=======================================
+ Hits 6299 6302 +3
Misses 490 490 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix LCP with size < previous LCP cf: https://bugs.chromium.org/p/chromium/issues/detail?id=1516655
Changes
Discarded the LCP entry if it has a size inferior to the previous LCP entry
Testing
I have gone over the contributing documentation.