♻️ [RUM-2445] simplify context manager sync with local storage #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal of this commit is to reduce the `logsPublicApi` and `rumPublicApi` modules by factorizing more of the "storeContextsAcrossPages" feature logic. Instead of creating a new context manager, this new implementation simply subscribe to the existing one. The behavior should be the same as before.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2562 +/- ##
==========================================
+ Coverage 92.85% 92.87% +0.02%
==========================================
Files 228 228
Lines 6744 6735 -9
Branches 1480 1480
==========================================
- Hits 6262 6255 -7
+ Misses 482 480 -2 ☔ View full report in Codecov by Sentry. |
|
/to-staging |
|
🚂 Branch Integration: 2 builds ahead, merge in < 7m Commit 329894e32e will soon be integrated into staging-02. There are 2 builds ahead! (estimated merge in less than 7m) you can cancel this operation by commenting your pull request with |
|
🚂 Branch Integration: This commit was successfully integrated Commit 329894e32e has been merged into staging-02 in merge commit f9d33160de. Check out the triggered pipeline on Gitlab 🦊 |
amortemousque
approved these changes
Jan 15, 2024
bcaudan
approved these changes
Jan 15, 2024
BenoitZugmeyer
deleted the
benoit/consent--simplify-stored-context-manager
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The goal of this commit is to reduce the
logsPublicApiandrumPublicApimodules by factorizing more of the"storeContextsAcrossPages" feature logic.
Changes
Instead of creating a new context manager, this new implementation simply subscribe to the existing one. The behavior should be the same as before.
Testing
I have gone over the contributing documentation.