✨ [RUMF-1518] implement a new API to stop the RUM session #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adjust the function name to unify the 'delete' action naming
BenoitZugmeyer
commented
Mar 8, 2023
| @@ -64,6 +65,7 @@ export function makeRumPublicApi( | |||
|
|
|||
| let getInternalContextStrategy: StartRumResult['getInternalContext'] = () => undefined | |||
| let getInitConfigurationStrategy = (): InitConfiguration | undefined => undefined | |||
| let stopSessionStrategy: () => void = noop | |||
There was a problem hiding this comment.
💭 thought: we didn't discuss what should happen when calling stopSession() before RUM is started. We might want to do something before GA
bcaudan
approved these changes
Mar 9, 2023
amortemousque
approved these changes
Mar 10, 2023
BenoitZugmeyer
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2064 +/- ##
==========================================
+ Coverage 93.46% 93.58% +0.11%
==========================================
Files 159 159
Lines 5506 5515 +9
Branches 1259 1262 +3
==========================================
+ Hits 5146 5161 +15
+ Misses 360 354 -6
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bcaudan
reviewed
Mar 24, 2023
bcaudan
reviewed
Mar 24, 2023
The original `findSessionCookie` suffered from the same edge case where the cookie is returned but its value is empty. Let's update it to the new implementation I went for, so it simplifies its usage.
bcaudan
approved these changes
Mar 27, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Let SDK users have more control on when RUM sessions should end.
Changes
stopSession()Testing
I have gone over the contributing documentation.