Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUMF-1286] test for expected features before starting recording #1719

Merged
merged 4 commits into from
Sep 5, 2022

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Sep 2, 2022

Motivation

Don't crash with telemetry errors when start recording on unsupported browsers

Changes

Do some light feature test before returning the actual recording API

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested review from a team as code owners September 2, 2022 16:14
@N-Boutaib N-Boutaib requested a review from a team September 2, 2022 16:26
@BenoitZugmeyer BenoitZugmeyer merged commit 16ae37e into main Sep 5, 2022
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/feature-test-before-record branch September 5, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants