Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logger Global Context APIs #1695

Merged
merged 9 commits into from
Aug 24, 2022

Conversation

liywjl
Copy link
Contributor

@liywjl liywjl commented Aug 16, 2022

Motivation

Update the Doc to reflect the updated Logger Global Context APIs. Relates to changes make in RUM Global Context DataDog/documentation#15013

Changes

  • Change the API names
  • Add removeGlobalContextProperty and clearGlobalContext examples

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple tiny edits

packages/logs/README.md Outdated Show resolved Hide resolved
packages/logs/README.md Outdated Show resolved Hide resolved
liywjl and others added 3 commits August 17, 2022 09:17
Co-authored-by: Heston Hoffman <hestonhoffman@gmail.com>
Co-authored-by: Heston Hoffman <hestonhoffman@gmail.com>
packages/logs/README.md Outdated Show resolved Hide resolved
packages/logs/README.md Outdated Show resolved Hide resolved
@liywjl liywjl merged commit d62c738 into main Aug 24, 2022
@liywjl liywjl deleted the william.lacroix/update-logger-global-context-APIs branch August 24, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants