Prerelease v4 #1241
Merged
Prerelease v4 #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ♻️ [RUMF-827] add function to build tags at a higher level * ✨ [RUMF-827] sanitize tags * 👌 simplify implementation * Single warning message * Keep sanitization to make sure we can't forge multiple tags from a single value * Removed the "ending semicolon" restriction since it only applies if there is no other semicolon in the whole tag (ex: "env:bar:" and "env::" are valid, but "env:" is not). Here, we are sure there is a semicolon, since we add one ourselves. * ✅ use valid tag values in tests
* 🔥 [RUMF-1094] remove deprecated attributes * ✅ revamp privacy.spec tests To have a better vision on what's being tested by `privacy.spec`, some cleanup was necessary. I took the opportunity to remove some deprecated variables to improve things here. * `getNodeSelfPrivacyLevel`: consolidate tests with more test cases and highlight current modes priority * `getNodePrivacyLevel`: remove tests cases when they are already handled by `getNodeSelfPrivacyLevel` and consolidate tests on fallback value and inheritance * `serializeDocumentNode`: move those tests to `serialize.spec` since we don't use privacy functions here As well as a few cosmetic changes.
…ext (#1200) * Use the programmatic action attribute instead of innertext for fetching the textual content Use the programmatic action attribute instead of innertext for fetching the textual content * Addressing the review comments * also consider programmatic action names from user defined attribute * 🐛 fix compatibility with IE11 * 👌 move tests into a more appropriate `describe` Co-authored-by: Benoît Zugmeyer <benoit.zugmeyer@datadoghq.com>
This commit make sure class names and attributes are treated equally, and that the most restrictive privacy level takes precedence over the other.
amortemousque
approved these changes
Jan 4, 2022
bcaudan
approved these changes
Jan 4, 2022
cswatt
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Release the next major version of the SDK. See Rendered migration guide and breaking changes
I have gone over the contributing documentation.