⚗[REPLAY-465] Base tag support (feature flagged): Remove URL transformation from relative to absolute #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagracey
changed the title
acorretti
approved these changes
Oct 4, 2021
jagracey
changed the title
bcaudan
approved these changes
Oct 4, 2021
…on-feature-flagged
| @@ -58,6 +64,9 @@ export function makeSrcsetUrlsAbsolute(attributeValue: string, baseUrl: string) | |||
|
|
|||
| export function makeUrlAbsolute(url: string, baseUrl: string): string { | |||
| try { | |||
| if (isExperimentalFeatureEnabled('base-tag')) { | |||
| return url.trim() | |||
There was a problem hiding this comment.
Do you need the .trim() here? I'd suggest removing it.
There was a problem hiding this comment.
I was pondering that myself. Why did we trim in the first place? Updated in the meantime.
Codecov Report
@@ Coverage Diff @@
## main #1106 +/- ##
==========================================
- Coverage 89.07% 89.04% -0.04%
==========================================
Files 91 91
Lines 4193 4199 +6
Branches 956 959 +3
==========================================
+ Hits 3735 3739 +4
- Misses 458 460 +2
Continue to review full report at Codecov.
|
jagracey
deleted the
john.gracey/remove-absolute-url-transformation-feature-flagged
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As per internal RFC "Supporting Replay of Relative URLs When Tag Used", we want to support the tag. In short, this tag will cause the document to resolve relative URLs with the provided URL instead.
Changes
We don't need to transform URLs from relative to absolute on the SDK recorder side. Instead we will handle this on the replay side.
Testing
Removes tests for code that transforms URLs. Manual testing for now behind a feature flag.
I have gone over the contributing documentation.