Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [RUMF-1033] request parameters into proxy url #1087

Merged
merged 9 commits into from
Sep 30, 2021

Conversation

amortemousque
Copy link
Collaborator

Motivation

When proxy is enabled dd-request-id and batch_time should be inside ddforward

Changes

  • Update transport configuration to expose endpoint builders
  • Update http request to use the builder to build the intake url
  • Update all endpoint refs

Testing

Locally, Unit


I have gone over the contributing documentation.

@amortemousque amortemousque requested review from a team as code owners September 29, 2021 07:49
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2021

Codecov Report

Merging #1087 (c0b3c49) into main (65e33f0) will decrease coverage by 0.00%.
The diff coverage is 91.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1087      +/-   ##
==========================================
- Coverage   89.17%   89.16%   -0.01%     
==========================================
  Files          90       90              
  Lines        4174     4172       -2     
  Branches      952      950       -2     
==========================================
- Hits         3722     3720       -2     
  Misses        452      452              
Impacted Files Coverage Δ
packages/logs/src/boot/startLogs.ts 72.91% <66.66%> (ø)
packages/rum-core/src/transport/batch.ts 77.14% <66.66%> (ø)
packages/core/src/domain/internalMonitoring.ts 95.52% <75.00%> (ø)
...s/core/src/domain/configuration/endpointBuilder.ts 100.00% <100.00%> (ø)
...src/domain/configuration/transportConfiguration.ts 100.00% <100.00%> (ø)
packages/core/src/tools/utils.ts 87.14% <100.00%> (ø)
packages/core/src/transport/httpRequest.ts 96.66% <100.00%> (-0.40%) ⬇️
packages/rum/src/boot/startRecording.ts 100.00% <100.00%> (ø)
packages/rum/src/transport/send.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65e33f0...c0b3c49. Read the comment docs.

@amortemousque amortemousque force-pushed the aymeric/request-parameters-into-proxy-url branch from f31fa9d to 0b56abe Compare September 29, 2021 07:51
Copy link
Contributor

@bcaudan bcaudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@amortemousque amortemousque merged commit a04cff5 into main Sep 30, 2021
@amortemousque amortemousque deleted the aymeric/request-parameters-into-proxy-url branch September 30, 2021 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants