Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 prevent recording to start when session renewed before onload #1009

Merged
merged 2 commits into from
Aug 26, 2021

Conversation

BenoitZugmeyer
Copy link
Member

Motivation

When the session is renewed before onload, there may be a case where the recording is incorrectly started.
This shouldn't happen that often, but it bothered me.

Changes

Stop the recording during session renew if it is starting.

Testing

CI


I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner August 24, 2021 09:41
Copy link
Contributor

@webNeat webNeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@codecov-commenter
Copy link

Codecov Report

Merging #1009 (1423672) into main (4cd9389) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1009   +/-   ##
=======================================
  Coverage   89.05%   89.05%           
=======================================
  Files          86       86           
  Lines        4119     4119           
  Branches      946      946           
=======================================
  Hits         3668     3668           
  Misses        451      451           
Impacted Files Coverage Δ
packages/rum/src/boot/recorderApi.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cd9389...1423672. Read the comment docs.

@BenoitZugmeyer BenoitZugmeyer merged commit 864dbea into main Aug 26, 2021
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/prevent-start-before-onload branch August 26, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants