AJ-954: submit deps for dependabot #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidangb
changed the title
calypsomatic
reviewed
Apr 6, 2023
| @@ -0,0 +1,22 @@ | |||
| name: Publish Docker Images to GCR and ACR | |||
There was a problem hiding this comment.
Is this name copypasta?
calypsomatic
approved these changes
Apr 6, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
yuliadub
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github's dependabot analysis has limited support for Gradle, which will not work out of the box for our project. You can see WDS's depdencies here: https://github.com/DataBiosphere/terra-workspace-data-service/network/dependencies - right now, there's no Java dependencies listed because Dependabot isn't parsing Gradle. See this simple summary or details in this issue report for explanation of the Dependabot/Gradle issues.
So, this PR sets up the gradle-dependency-submission action to submit gradle dependencies directly to the Dependency Submission API. This will allow dependency analysis, but not automatic PR creation.
According to the action author:
So, do we just merge and see if it works?