CORE-310: add 'Estimated' or 'Final cost' to workflow costs #5257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
davidangb
requested review from
a team,
calypsomatic,
marctalbott and
kevinpalis
and removed request for
a team and
calypsomatic
marctalbott
approved these changes
Feb 20, 2025
kevinmarete
approved these changes
Feb 20, 2025
kevinpalis
approved these changes
Feb 20, 2025
This was referenced Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: https://broadworkbench.atlassian.net/browse/CORE-310
Dependencies
This requires broadinstitute/rawls#3172 for full functionality. Without that Rawls PR, this terra-ui PR will always show either "Final cost" or nothing; we'll never show "Estimated". I think it's good to get this PR out first, then follow up with the Rawls PR later; that way, we'll ensure we have the proper annotation for costs before we start showing esimated costs.
Summary of changes:
Adds a "Final cost" or "Estimated" annotation to the Run Cost column when displaying workflows.
Bonus fix: vertically aligns the "Status" column to be consistent with the rest of the table.
before:
after:
when a workflow has a cost, we give it a final/estimated annotation:
when a workflow has "n/a" for cost, we omit the annotation:
Testing strategy
Tested by running locally. I could not find an existing test suite for the
SubmissionWorkflowsTablecomponent or the SubmissionDetails.js file, and this felt small enough that I didn't want to blow up scope to create a new one.