CORE-108: Add local DUOS url with port #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rushtong
changed the title
rushtong
commented
Oct 24, 2024
Comment on lines
101
to
+102
| "https://localhost.dsde-dev.broadinstitute.org/", | ||
| "https://localhost.dsde-dev.broadinstitute.org:3000/", |
There was a problem hiding this comment.
Note to reviewers, we use both of these urls. When running as a docker image, the app runs on port 80. When running via npm start, the app runs on port 3000
|
samanehsan
approved these changes
Oct 24, 2024
kevinmarete
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://broadworkbench.atlassian.net/browse/CORE-108
What: Add local version of DUOS to list of allowed era-commons redirect URIs.
Why: Arbitrary redirect uris are not allowed due to security considerations. When the oauth provider does the redirect it includes information to allow the user to link their account and retrieve an access token. Note that this is related to #216
How: Update providers.yaml