ID-1330 Orchestration can PUT eRA Commons accounts #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlangs
commented
Jul 25, 2024
| $ref: '#/components/responses/PermissionDenied' | ||
| '500': | ||
| $ref: '#/components/responses/ServerError' | ||
| /api/admin/v1/{provider}/userForExternalId/{externalId}: |
There was a problem hiding this comment.
moved the api version to the correct place.
tlangs
commented
Jul 25, 2024
| .isAuthenticated(true) | ||
| .provider(provider) | ||
| .userId(adminLinkInfo.getUserId()) | ||
| .refreshToken("fake-refresh-token") |
There was a problem hiding this comment.
I've made it so that trying to get an access token from an eRA Commons account fails with a helpful message instead of some esoteric permissions error.
tlangs
commented
Jul 25, 2024
| @@ -66,9 +111,9 @@ void testGetLinkedAccountForExternalIdNonAdmin() throws Exception { | |||
| var inputLinkedAccount = TestUtils.createRandomLinkedAccount(Provider.ERA_COMMONS); | |||
|
|
|||
| mvc.perform( | |||
| get("/api/admin/" | |||
| get("/api/admin/v1/" | |||
There was a problem hiding this comment.
Result of putting the API Version in the right place.
|
Ghost-in-a-Jar
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://broadworkbench.atlassian.net/browse/ID-1330
Since RAS is on the slow-end of getting us the correct redirects for OAuth login with eRA Commons credentials, we should just have ECM store the result of the SAML handshake. This PR lets Orch
PUTa linked account for eRA Commons. It also makes getting a token from a linked eRA Account throw anUnsupportedOperationException, since we don't have a real refresh token to get an access token with.