WM-2123: Request callback in submissions to Cromwell #205

cjllanwarne · 2023-09-25T19:25:43Z

Adds an additional workflow option to activate workflow completion callbacks (see https://github.com/broadinstitute/cromwell/pull/7213/files under docs/cromwell_features/WorkflowCallback.md).

Note: doesn't start doing until without also having:

Merging of WX-1217 Workflow completion callback broadinstitute/cromwell#7213
Terra-helmfile changes to set up callback config in CBAS and in Cromwell Runner

dillydally414 · 2023-09-26T15:26:41Z

service/src/test/java/bio/terra/cbas/controllers/TestRunSetsApiController.java


    // Workflow options should reflect the final workflow log directory.
    // write_to_cache should always be true. read_from_cache should match the provided call caching
    // option.
    String expected =
-        "{\"final_workflow_log_dir\":\"my/final/workflow/log/dir\",\"read_from_cache\":true,\"write_to_cache\":true}";
+        "{\"final_workflow_log_dir\":\"my/final/workflow/log/dir\",\"read_from_cache\":true,\"workflow_callback_uri\":\"http://localhost:8080api/batch/v1/runs/results\",\"write_to_cache\":true}";


Do we expect external URI to have a trailing slash? If so, might be good to reflect that in tests here.
EDIT: Just looked at the terra-helmfile PR and it seems we do provide a trailing slash, so this is more of a testing nit than a functionality consideration