-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promotion 2024-09-10 anvilprod (#6555) #6561
Conversation
Some canned table rows contain conflicting values for the entities' UUIDs: the primary keys do not match the document IDs in the `content` column. We suspect this is the result of a bug in the recently-retired `recan_bundle_tdr` script. Soon, we will replace file names in HCA bundles with entity references, at which point these inconsistent UUIDs would break the build.
There are no metadata documents associated with these entries. Soon we will convert the manifest to a dictionary using entity references as keys, at which point it will become impossible for bundles to include such dangling entries. Removing them preemptively proves that they have no effect on any of our tests.
This makes #4565 obsolete/invalid
… when PR lands on `develop`
@@ -140,7 +140,7 @@ | |||
def fetch_bundle(self, bundle_fqid: DSSBundleFQID) -> DSSBundle: | |||
assert False, 'DSS is EOL' | |||
# noinspection PyUnreachableCode | |||
return DSSBundle(fqid=bundle_fqid, manifest=[], metadata_files={}) | |||
return DSSBundle(fqid=bundle_fqid, manifest={}, metadata={}, links={}) |
Check warning
Code scanning / CodeQL
Unreachable code Warning
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## anvilprod #6561 +/- ##
==========================================
Coverage 85.38% 85.38%
==========================================
Files 156 155 -1
Lines 20767 20735 -32
==========================================
- Hits 17731 17704 -27
+ Misses 3036 3031 -5 ☔ View full report in Codecov by Sentry. |
Connected issue: #6555
Checklist
Author
anvilprod
promotions/yyyy-mm-dd-anvilprod
Promotion yyyy-mm-dd
anvilprod
Author (reindex, API changes)
reindex:anvilprod
or the changes introduced by it will not require reindexing ofanvilprod
reindex:partial
and its description documents the specific reindexing procedure foranvilprod
or requires a full reindex or is not labeledreindex:anvilprod
Author (upgrading deployments)
upgrade
or does not require upgrading deploymentsdeploy:shared
or does not modifydocker_images.json
, and does not require deploying theshared
component for any other reasondeploy:gitlab
or does not require deploying thegitlab
componentdeploy:runner
or does not require deploying therunner
imageSystem administrator (after approval)
no sandbox
Operator (before pushing merge the commit)
_select anvilprod.shared && CI_COMMIT_REF_NAME=anvilprod make -C terraform/shared apply_keep_unused
or this PR is not labeleddeploy:shared
anvilprod
(see operator manual for details) or this PR is not labeledbackup:gitlab
_select anvilprod.gitlab && CI_COMMIT_REF_NAME=anvilprod make -C terraform/gitlab apply
or this PR is not labeleddeploy:gitlab
deploy:gitlab
deploy:gitlab
System administrator
anvilprod.gitlab
are complete or this PR is not labeleddeploy:gitlab
Operator (before pushing merge the commit)
_select anvilprod.gitlab && make -C terraform/gitlab/runner
or this PR is not labeleddeploy:runner
sandbox
label or PR is labeledno sandbox
anvilprod
or PR is labeledno sandbox
hammerbox
deployment or PR is labeledno sandbox
hammerbox
deployment or PR is labeledno sandbox
p
tagsOperator (after pushing the merge commit)
anvilprod
anvilprod
anvilprod
_select anvilprod.shared && make -C terraform/shared apply
or this PR is not labeleddeploy:shared
anvilprod
Operator (reindex)
anvilprod
or this PR is neither labeledreindex:partial
norreindex:anvilprod
anvilprod
or this PR is neither labeledreindex:partial
norreindex:anvilprod
anvilprod
or this PR is neither labeledreindex:partial
norreindex:anvilprod
anvilprod
or this PR does not require reindexinganvilprod
anvilprod
or this PR does not require reindexinganvilprod
anvilprod
or this PR does not require reindexinganvilprod
Operator
System administrator
Shorthand for review comments
L
line is too longW
line wrapping is wrongQ
bad quotesF
other formatting problem