Eliminate RepositoryPlugin.list_partitions (#6531) #6554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadove-ucsc
added
the
upgrade
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -143,7 +138,7 @@ | |||
| # https://github.com/DataBiosphere/azul/issues/2621 | |||
| es_type = 'keyword' | |||
|
|
|||
| def to_index(self, value_unit: Optional[JSON]) -> str: | |||
| def to_index(self, value_unit: JSON | None) -> str: | |||
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns Note
nadove-ucsc
force-pushed
the
issues/nadove-ucsc/6531-eliminate-list-partitions
branch
from
850ebdb
to
e125c68
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6554 +/- ##
===========================================
+ Coverage 85.38% 85.46% +0.08%
===========================================
Files 155 155
Lines 20754 20740 -14
===========================================
+ Hits 17720 17726 +6
+ Misses 3034 3014 -20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nadove-ucsc
force-pushed
the
issues/nadove-ucsc/6531-eliminate-list-partitions
branch
7 times, most recently
from
a8dae53
to
7f8360f
Compare
dsotirho-ucsc
requested changes
Sep 13, 2024
| @@ -397,14 +392,14 @@ def __init__(self, id: str, title: str, category: SubmitterCategory): | |||
| self.by_id[id] = self | |||
|
|
|||
| @classmethod | |||
| def for_id(cls, submitter_id: str) -> Optional['Submitter']: | |||
| def for_id(cls, submitter_id: str) -> 'Submitter | None': | |||
There was a problem hiding this comment.
Suggested change
| def for_id(cls, submitter_id: str) -> 'Submitter | None': | |
| def for_id(cls, submitter_id: str) -> Self | None: |
| try: | ||
| return cls.by_id[submitter_id] | ||
| except KeyError: | ||
| return None | ||
|
|
||
| @classmethod | ||
| def for_file(cls, file: api.File) -> Optional['Submitter']: | ||
| def for_file(cls, file: api.File) -> 'Submitter | None': |
There was a problem hiding this comment.
Suggested change
| def for_file(cls, file: api.File) -> 'Submitter | None': | |
| def for_file(cls, file: api.File) -> Self | None: |
| mksrc('bigquery', 'datarepo-dev-2a4ab485', 'hca_dev_d2111fac3fc44f429b6d32cd6a828267__20210830_20230215'), | ||
| mksrc('bigquery', 'datarepo-dev-1005632d', 'hca_dev_d3ac7c1b53024804b611dad9f89c049d__20210827_20230215'), | ||
| mksrc('bigquery', 'datarepo-dev-8709b362', 'hca_dev_df88f39f01a84b5b92f43177d6c0f242__20210827_20230215'), | ||
| mksrc('bigquery', 'datarepo-dev-e1712bfa', 'hca_dev_e526d91dcf3a44cb80c5fd7676b55a1d__20210902_20230215'), | ||
| ])) | ||
|
|
||
| lungmap_sources = mkdict({}, 2, mkdelta([ |
There was a problem hiding this comment.
The old subgraphs argument 1 needs to be removed from the lungmap_sources sources.
nadove-ucsc
force-pushed
the
issues/nadove-ucsc/6531-eliminate-list-partitions
branch
2 times, most recently
from
ecc64da
to
1c36709
Compare
nadove-ucsc
added
reindex:dev
nadove-ucsc
force-pushed
the
issues/nadove-ucsc/6531-eliminate-list-partitions
branch
3 times, most recently
from
a6390ce
to
da3b971
Compare
dsotirho-ucsc
requested changes
Sep 18, 2024
|
|
||
| return source, partition_prefix, fqids | ||
|
|
||
| def _list_bundles(self, |
There was a problem hiding this comment.
A comment in _prepare_notifications() that references _list_bundles() needs to be updated.
|
Assigned @dsotirho-ucsc for a second approval on this PR, as prescribed in Slack. |
dsotirho-ucsc
requested changes
Sep 27, 2024
|
As discussed at PL, I'm choosing not to incorporate every potential use of |
nadove-ucsc
requested review from
hannes-ucsc
and removed request for
hannes-ucsc
nadove-ucsc
dismissed
hannes-ucsc’s stale review
Hannes agreed at PL this morning that we could merge the PR in his absence. The changes he requested in his latest review have been addressed verbatim.
Security design review
|
dsotirho-ucsc
added
the
sandbox
achave11-ucsc
deleted the
issues/nadove-ucsc/6531-eliminate-list-partitions
branch
|
Removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected issues: #6531
Note: this is to be promoted separately.
Checklist
Author
developissues/<GitHub handle of author>/<issue#>-<slug>1 when the issue title describes a problem, the corresponding PR
title is
Fix:followed by the issue titleAuthor (partiality)
ptag to titles of partial commitspartialor completely resolves all connected issuespartiallabelAuthor (chains)
baseor this PR is not chained to another PRchainedor is not chained to another PRAuthor (reindex, API changes)
rtag to commit title or the changes introduced by this PR will not require reindexing of any deploymentreindex:devor the changes introduced by it will not require reindexing ofdevreindex:anvildevor the changes introduced by it will not require reindexing ofanvildevreindex:anvilprodor the changes introduced by it will not require reindexing ofanvilprodreindex:prodor the changes introduced by it will not require reindexing ofprodreindex:partialand its description documents the specific reindexing procedure fordev,anvildev,anvilprodandprodor requires a full reindex or carries none of the labelsreindex:dev,reindex:anvildev,reindex:anvilprodandreindex:prodAPIor this PR does not modify a REST APIa(A) tag to commit title for backwards (in)compatible changes or this PR does not modify a REST APIapp.pyor this PR does not modify a REST APIAuthor (upgrading deployments)
make docker_images.jsonand committed the resulting changes or this PR does not modifyazul_docker_images, or any other variables referenced in the definition of that variableutag to commit title or this PR does not require upgrading deploymentsupgradeor does not require upgrading deploymentsdeploy:sharedor does not modifydocker_images.json, and does not require deploying thesharedcomponent for any other reasondeploy:gitlabor does not require deploying thegitlabcomponentdeploy:runneror does not require deploying therunnerimageAuthor (hotfixes)
Ftag to main commit title or this PR does not include permanent fix for a temporary hotfixanvilprodandprod) have temporary hotfixes for any of the issues connected to this PRAuthor (before every review)
develop, squashed old fixupsmake requirements_updateor this PR does not modifyrequirements*.txt,common.mk,MakefileandDockerfileRtag to commit title or this PR does not modifyrequirements*.txtreqsor does not modifyrequirements*.txtmake integration_testpasses in personal deployment or this PR does not modify functionality that could affect the IT outcomePeer reviewer (after approval)
System administrator (after approval)
Actually approved the PRdemoorno demono demono sandboxN reviewslabel is accurateOperator (before pushing merge the commit)
reindex:…labels andrcommit title tagno demodevelop_select dev.shared && CI_COMMIT_REF_NAME=develop make -C terraform/shared apply_keep_unusedor this PR is not labeleddeploy:shared_select dev.gitlab && CI_COMMIT_REF_NAME=develop make -C terraform/gitlab applyor this PR is not labeleddeploy:gitlab_select anvildev.shared && CI_COMMIT_REF_NAME=develop make -C terraform/shared apply_keep_unusedor this PR is not labeleddeploy:shared_select anvildev.gitlab && CI_COMMIT_REF_NAME=develop make -C terraform/gitlab applyor this PR is not labeleddeploy:gitlabdeploy:gitlabdeploy:gitlabSystem administrator
dev.gitlabare complete or this PR is not labeleddeploy:gitlabanvildev.gitlabare complete or this PR is not labeleddeploy:gitlabOperator (before pushing merge the commit)
_select dev.gitlab && make -C terraform/gitlab/runneror this PR is not labeleddeploy:runner_select anvildev.gitlab && make -C terraform/gitlab/runneror this PR is not labeleddeploy:runnersandboxlabel or PR is labeledno sandboxdevor PR is labeledno sandboxanvildevor PR is labeledno sandboxsandboxdeployment or PR is labeledno sandboxanvilboxdeployment or PR is labeledno sandboxsandboxdeployment or PR is labeledno sandboxanvilboxdeployment or PR is labeledno sandboxsandboxor this PR does not remove catalogs or otherwise causes unreferenced indices indevanvilboxor this PR does not remove catalogs or otherwise causes unreferenced indices inanvildevsandboxor this PR is not labeledreindex:devanvilboxor this PR is not labeledreindex:anvildevsandboxor this PR is not labeledreindex:devanvilboxor this PR is not labeledreindex:anvildevdevelopto serve as a baseline (devJob 100952,anvildevJob 48695)pif the PR is also labeledpartialOperator (chain shortening)
developor this PR is not labeledbasechainedlabel from the blocked PR or this PR is not labeledbasebasebaselabel from this PR or this PR is not labeledbaseOperator (after pushing the merge commit)
devanvildevdevdevBuild passes on GitLabhttps://gitlab.anvil.gi.ucsc.edu/ucsc/azul/-/jobs/48994anvildevanvildev_select dev.shared && make -C terraform/shared applyor this PR is not labeleddeploy:shared_select anvildev.shared && make -C terraform/shared applyor this PR is not labeleddeploy:shareddevanvildevOperator (reindex)
devor this PR is neither labeledreindex:partialnorreindex:devanvildevor this PR is neither labeledreindex:partialnorreindex:anvildevdevor this PR is neither labeledreindex:partialnorreindex:devanvildevor this PR is neither labeledreindex:partialnorreindex:anvildevdevor this PR is neither labeledreindex:partialnorreindex:devanvildevor this PR is neither labeledreindex:partialnorreindex:anvildevdevor this PR does not require reindexingdev(Job 101121)anvildevor this PR does not require reindexinganvildev(Job 48855)devor this PR does not require reindexingdevanvildevor this PR does not require reindexinganvildevdevor this PR does not require reindexingdevanvildevor this PR does not require reindexinganvildevOperator
deploy:shared,deploy:gitlab,deploy:runner,API,reindex:partial,reindex:anvilprodandreindex:prodlabels to the next promotion PRs or this PR carries none of these labelsdeploy:shared,deploy:gitlab,deploy:runner,API,reindex:partial,reindex:anvilprodandreindex:prodlabels, from the description of this PR to that of the next promotion PRs or this PR carries none of these labelsShorthand for review comments
Lline is too longWline wrapping is wrongQbad quotesFother formatting problem