Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promotion 2024-09-03 prod (#6539) #6544

Merged
merged 48 commits into from
Sep 6, 2024
Merged

Conversation

achave11-ucsc
Copy link
Member

@achave11-ucsc achave11-ucsc commented Sep 5, 2024

Connected issue: #6539

Checklist

Author

  • Target branch is prod
  • Name of PR branch matches promotions/yyyy-mm-dd-prod
  • On ZenHub, PR is connected to the promotion issue it resolves
  • PR description links to connected issue
  • Title of connected issue matches Promotion yyyy-mm-dd
  • PR title starts with title of connected issue followed by prod
  • PR title references the connected issue

Author (reindex, API changes)

  • This PR is labeled reindex:prod or the changes introduced by it will not require reindexing of prod
  • This PR is labeled reindex:partial and its description documents the specific reindexing procedure for prod or requires a full reindex or is not labeledreindex:prod

Author (upgrading deployments)

  • This PR is labeled upgrade or does not require upgrading deployments
  • This PR is labeled deploy:shared or does not modify docker_images.json, and does not require deploying the shared component for any other reason
  • This PR is labeled deploy:gitlab or does not require deploying the gitlab component
  • This PR is labeled deploy:runner or does not require deploying the runner image

System administrator (after approval)

  • Actually approved the PR
  • Labeled PR as no sandbox
  • Moved connected issue to Approved column
  • PR is assigned to only the operator

Operator (before pushing merge the commit)

  • Pushed PR branch to GitHub
  • Ran _select prod.shared && CI_COMMIT_REF_NAME=prod make -C terraform/shared apply or this PR is not labeled deploy:shared
  • Made a backup of the GitLab data volume in prod (see operator manual for details) or this PR is not labeled backup:gitlab
  • Ran _select prod.gitlab && CI_COMMIT_REF_NAME=prod make -C terraform/gitlab apply or this PR is not labeled deploy:gitlab
  • Checked the items in the next section or this PR is labeled deploy:gitlab
  • PR is assigned to only the system administrator or this PR is not labeled deploy:gitlab

System administrator

  • Background migrations for prod.gitlab are complete or this PR is not labeled deploy:gitlab
  • PR is assigned to only the operator

Operator (before pushing merge the commit)

  • Ran _select prod.gitlab && make -C terraform/gitlab/runner or this PR is not labeled deploy:runner
  • The title of the merge commit starts with the title of this PR
  • Added PR # reference to merge commit title
  • Collected commit title tags in merge commit title but excluded any p tags
  • Pushed merge commit to GitHub

Operator (after pushing the merge commit)

  • Pushed merge commit to GitLab prod
  • Build passes on GitLab prod
  • Reviewed build logs for anomalies on GitLab prod
  • Deleted PR branch from GitHub
  • Moved connected issue to Merged stable column on ZenHub
  • Moved promoted issues from Merged lower to Merged stable column on ZenHub
  • Moved promoted issues from Lower to Stable column on ZenHub

Operator (reindex)

  • Deindexed all unreferenced catalogs in prod or this PR is neither labeled reindex:partial nor reindex:prod
  • Deindexed specific sources in prod or this PR is neither labeled reindex:partial nor reindex:prod
  • Indexed specific sources in prod or this PR is neither labeled reindex:partial nor reindex:prod
  • Started reindex in prod or this PR does not require reindexing prod
  • Checked for, triaged and possibly requeued messages in both fail queues in prod or this PR does not require reindexing prod
  • Emptied fail queues in prod or this PR does not require reindexing prod

Operator

  • PR is assigned to only the system administrator

System administrator

Shorthand for review comments

  • L line is too long
  • W line wrapping is wrong
  • Q bad quotes
  • F other formatting problem

dsotirho-ucsc and others added 30 commits August 20, 2024 17:08
Refactor attributes and variables
Refactor persistent representation
Predict and track hashes of mirrored multi-platform images
Use temporary file to share Docker CLI credentials with Skopeo
- Pin base image of Azul and runner images to digest
- Enforce that azul_docker_registry is empty or ends in slash …
- … but remove slash in azul.config.docker_registry
@github-actions github-actions bot added the orange [process] Done by the Azul team label Sep 5, 2024
@achave11-ucsc achave11-ucsc added upgrade [process] PR includes commit requiring manual upgrade deploy:gitlab [process] PR requires deploying `gitlab` component deploy:shared [process] PR requires deploying `shared` component deploy:runner [process] PR requires deploying `runner` component backup:gitlab [process] PR requires backing up GitLab instances labels Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 71.67630% with 49 lines in your changes missing coverage. Please review.

Project coverage is 85.38%. Comparing base (d769f27) to head (ec4e3b1).
Report is 3 commits behind head on prod.

Files with missing lines Patch % Lines
src/azul/docker.py 60.00% 46 Missing ⚠️
src/azul/__init__.py 75.00% 2 Missing ⚠️
src/azul/service/async_manifest_service.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             prod    #6544      +/-   ##
==========================================
- Coverage   85.39%   85.38%   -0.02%     
==========================================
  Files         156      156              
  Lines       20682    20767      +85     
==========================================
+ Hits        17662    17731      +69     
- Misses       3020     3036      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Coverage Status

coverage: 85.398% (-0.02%) from 85.415%
when pulling ec4e3b1 on promotions/2024-09-03-prod
into 32ba09e on prod.

@hannes-ucsc hannes-ucsc added 0 reviews [process] Lead didn't request any changes no sandbox [process] PR will not be tested in the sandbox labels Sep 5, 2024
@achave11-ucsc achave11-ucsc merged commit 168c6a7 into prod Sep 6, 2024
387 checks passed
@achave11-ucsc achave11-ucsc deleted the promotions/2024-09-03-prod branch September 7, 2024 00:31
@hannes-ucsc hannes-ucsc removed their assignment Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 reviews [process] Lead didn't request any changes backup:gitlab [process] PR requires backing up GitLab instances deploy:gitlab [process] PR requires deploying `gitlab` component deploy:runner [process] PR requires deploying `runner` component deploy:shared [process] PR requires deploying `shared` component no sandbox [process] PR will not be tested in the sandbox orange [process] Done by the Azul team upgrade [process] PR includes commit requiring manual upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants