Skip to content

Commit

Permalink
Add PR checklist item for triaging blockees
Browse files Browse the repository at this point in the history
… when PR lands on `develop`
  • Loading branch information
hannes-ucsc committed Sep 5, 2024
1 parent 6640a79 commit f42a38e
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/PULL_REQUEST_TEMPLATE/upgrade.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ Connected issue: #0000
- [ ] Added PR # reference to merge commit title
- [ ] Collected commit title tags in merge commit title <sub>but excluded any `p` tags</sub>
- [ ] Moved connected issue to *Merged lower* column in ZenHub
- [ ] Moved blocked issues to *Triage* <sub>or no issues are blocked on the connected issue</sub>
- [ ] Closed related Dependabot PRs with a comment referencing the corresponding commit in this PR <sub>or this PR does not include any such commits</sub>
- [ ] Pushed merge commit to GitHub

Expand Down
1 change: 1 addition & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ title is `Fix: ` followed by the issue title
- [ ] Added PR # reference to merge commit title
- [ ] Collected commit title tags in merge commit title <sub>but only included `p` if the PR is also labeled `partial`</sub>
- [ ] Moved connected issues to *Merged lower* column in ZenHub
- [ ] Moved blocked issues to *Triage* <sub>or no issues are blocked on the connected issues</sub>
- [ ] Pushed merge commit to GitHub


Expand Down
5 changes: 5 additions & 0 deletions .github/pull_request_template.md.template.py
Original file line number Diff line number Diff line change
Expand Up @@ -812,6 +812,11 @@ def emit(t: T, target_branch: str):
'Moved connected issue to *Merged stable* column in ZenHub',
f'Moved connected {t.issues} to *Merged lower* column in ZenHub')
}),
iif(target_branch == 'develop' and t is not T.backport, {
'type': 'cli',
'content': 'Moved blocked issues to *Triage*',
'alt': f'or no issues are blocked on the connected {t.issues}'
}),
iif(t is T.upgrade,
{
'type': 'cli',
Expand Down

0 comments on commit f42a38e

Please sign in to comment.