Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(toast)!: simplify toast configuration #82

Merged
merged 5 commits into from
Aug 14, 2023

Conversation

DatGuy1
Copy link
Owner

@DatGuy1 DatGuy1 commented Aug 13, 2023

BREAKING CHANGE: All the SetX methods have been removed

  • Toast.first_line/.second_line/.third_line reworked into a text_fields list
  • Instead of a multitude of SetX methods, the attributes should now be modified directly
  • Updated documentation to fit this

BREAKING CHANGE: All the SetX methods have been removed

- Toast.first_line/.second_line/.third_line reworked into a text_fields list
- Instead of a multitude of SetX methods, the attributes should now be modified directly
- Updated documentation to fit this
@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Merging #82 (afc2c09) into main (b0c5657) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
- Coverage   97.90%   97.84%   -0.07%     
==========================================
  Files          10       10              
  Lines         620      602      -18     
  Branches       85       86       +1     
==========================================
- Hits          607      589      -18     
  Misses         10       10              
  Partials        3        3              
Files Changed Coverage Δ
src/windows_toasts/toast.py 100.00% <100.00%> (ø)
src/windows_toasts/toast_document.py 99.32% <100.00%> (ø)
src/windows_toasts/toasters.py 96.26% <100.00%> (+0.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DatGuy1 DatGuy1 merged commit 0ed2e4c into main Aug 14, 2023
9 checks passed
@DatGuy1 DatGuy1 deleted the refactor/toast-simplify branch August 14, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant