This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
fix hq synth rates #6094
Merged
fix hq synth rates #6094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can we possibly recast it to enable using actual division? |
|
I mean if you're averse to float representation and really want fractional representation you could divide float literals (1./2.) and get the same number. Just can't divide int literals, or you'll get an int result. |
|
@isotor so about that testing our changes my dude :) |
|
@wrenffxi I'm fine with however this turns out but there was some discussion about clarity, /shrug I'll let someone either merge as is or tell you what they want here. |
zynjec
approved these changes
Jun 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
divide int literals (1/2), get an int output (0)