Skip to content
This repository has been archived by the owner on Apr 29, 2020. It is now read-only.

Client Version Update: 30190605_0 #6086

Merged
merged 7 commits into from
Jun 19, 2019
Merged

Client Version Update: 30190605_0 #6086

merged 7 commits into from
Jun 19, 2019

Conversation

wrenffxi
Copy link
Contributor

No description provided.

ibm2431
ibm2431 previously approved these changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@ibm2431 ibm2431 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have also confirmed that the event zones still have last month's event NPCs. (Hence why no shifts despite Shining Bless being over.)

zynjec
zynjec suggested changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@zynjec zynjec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're going to add the zone, please update MAX_ZONEID and add the zone name to the header, as well as update the id range for the !zone command.

sql/zone_weather.sql Show resolved Hide resolved
sql/zone_settings.sql Outdated Show resolved Hide resolved
zynjec
zynjec reviewed Jun 18, 2019
View reviewed changes
sql/npc_list.sql Show resolved Hide resolved
sql/npc_list.sql Show resolved Hide resolved
zynjec
zynjec previously approved these changes Jun 19, 2019
View reviewed changes
@wrenffxi
increase MAX_ZONEID in core and a few places where it's hard-coded in…
6939314 
… LUA

retail capture of two NPCs
Walk of Echoes [P] music and weather
@wrenffxi
Copy link
Contributor Author

missed Veridical Conflux's model/look in last commit. force-pushed a fix.

@zynjec zynjec merged commit a593f8b into DarkstarProject:master Jun 19, 2019
@wrenffxi wrenffxi deleted the version-update branch June 19, 2019 20:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zynjec zynjec zynjec approved these changes

@ibm2431 ibm2431 ibm2431 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wrenffxi @ibm2431 @zynjec