Add aarch64 support to raknet and CMakesLists #111

mixy1 · 2021-12-08T01:47:15Z

Added support for arm processors for DarkflameServer.
Tested on a Raspberry Pi 4 8gb (Ubuntu 20.04 LTS).

codeshaunted · 2021-12-08T02:16:02Z

Even if this compiles, do you have a MySQL connector library for ARM?

mixy1 · 2021-12-08T03:03:07Z

I wrote in the readme. The ubuntu repositories have the library libmysqlcppconn-dev compiled for aarch64
that is obtained as such
sudo apt-get -y install libmysqlcppconn-dev.
In fact in the CMakeLists.txt I depend on the fact that the server hoster has downloaded and installed the package onto their system.
tl;dr
CMakeLists.txt appends /usr/include/ to the include path
And also uses the mysqlcppconn in the link_libraries function.

codeshaunted · 2021-12-08T05:11:57Z

Have you ensured that this doesn't break anything on x86? Also is there any chance you could fetch the binaries like on x86 with a FetchContent call from anywhere, or is that not going to be possible?

jumpy-badger · 2021-12-08T09:13:52Z

I have also been looking into this and have what looks like a working build although not much testing done yet and still in progress, especially with the CmakeLists.txt (https://github.com/jumpy-badger/DarkflameServer/tree/AArch64-port).

From what I've been looking at the raknet defines in this look off, aarch64 and ps3 aren't compatible defines. Aarch64 has 8 float registers instead of 12 and is also not powerpc.

I've used the mariadb cpp connector in place of the mysql one and built it from source. It's required a few minimal code changes and seems to be working.

I should probably mention as well that the CMAKE_SYSTEM_PROCESSOR variable is not guaranteed to correspond to the target architecture.

mixy1 · 2021-12-08T11:20:53Z

I can confirm that x86 still compiles with my patches and works fine.

Regarding fetching the binaries I couldn't find them not as packages for distros. I do have the links for deb and rpm.
Maybe I should add the version to the apt-get install command? The other option I could see is adding the source and building from source like what the patch mentioned above is doing.

Regarding the raknet you're correct but it doesn't seem to matter since I arrived at gnarled forest and the server looked to run completely fine. I didn't really have time to look into what is actually happening so I just added the aarch64 flag without actually looking at the config so that I see if it even compiles, Turns out it even works perfectly 🤷‍♂️.

codeshaunted · 2021-12-08T13:43:10Z

Would probably be good to add a section to the README about ARM builds.

mixy1 · 2021-12-08T13:46:26Z

It's added in my patches.

jumpy-badger · 2021-12-08T14:55:55Z

Is pulling the ubuntu package going to work for other distros (e.g. arch)?

Building from source seems better (I think?). I couldn't get the mysql connector to compile from source which is why I switched to the mariadb one.

Are the DLU team okay with switching to the mariadbconnector for linux builds?
I've updated my branch and it should be ready now, is it worth pull requesting that?

mixy1 · 2021-12-08T14:57:42Z

I do think building from source seems better in this case. I'm fine with dropping my pull request to make way for @jumpy-badger's which looks to be identical apart for the mariadbconnector part.

mixy1 · 2021-12-08T15:06:38Z

Personal opinion though is that mysql connector should be switched completely to mariadb connector across the codebase, since it's not a good idea to mantain two different versions when mariadb can just replace it for all platforms.

jumpy-badger · 2021-12-08T15:12:30Z

I agree with that, thought it might be better to limit how much this affected other builds to start with and address a full switch in a separate issue.

codeshaunted · 2021-12-09T19:49:15Z

Honestly it is probably a better solution to drop standard MySQL support entirely and opt for MariaDB… @DarwinAnim8or @Wincent01 @MickVermeulen thoughts?

MickVermeulen · 2021-12-10T09:27:37Z

Seems like there’s no macOS binaries. I am in favor of it tho, I think supporting DLU on x86 and ARM is more important than which platform it specifically runs on. If we were to take that step I’d be in favor of dropping native Windows and macOS support in favor of using WSL and multipass for Ubuntu VMs. Will not only streamline the setup but will also make sure we can actually run on all platforms, native or not.

mixy1 · 2021-12-10T09:29:04Z

If we compile from source we shouldn't have to drop support for any platform though?

MickVermeulen · 2021-12-10T09:30:15Z

Fair enough, how are the build times for that?

mixy1 · 2021-12-10T09:56:28Z

Building only mariadb-connector-cpp on a raspberry pi 4 8gb
make -j4
real    3m39.490s
user    12m47.063s
sys     1m3.167s

I think that it would be smart to instead fetch the binaries for platforms that have them prebuilt and build the source only if a binary isn't available. Considering that 98% of the systems running this will be x86 windows and linux I think we should prefetch those binaries specifically(conditionally of course).
On another note I don't see why M1 mac shouldn't be supported after this patch.
Also we should merge @jumpy-badger's patch not mine as mine does not have mariadb.

MickVermeulen · 2021-12-11T12:56:36Z

I agree that building from source would be a good thing for macOS anyway, it would get rid of all the obscure symlinking build steps.

jumpy-badger · 2021-12-11T17:55:22Z

I'll update my branch so that every build uses the new connector and make a pull request then.

The mariadb connector looks like it should work with mysql databases but I'll check when I test a Windows build.

I don't have a Mac so someone verifying if it works on Mac once I've made the changes and submitting any fixes for it would be appreciated.

Fetching binaries for Windows should be fine but there aren't any generic ones to fetch for Linux so will have to build from source.

If we're gonna build from source on Linux and Mac should we just do the same for Windows?

MickVermeulen · 2021-12-12T09:27:21Z

I can verify on a Mac, let me know if you've updated the cmakefile to reflect building the mariadbconnector. Ideally I'd first just have a version that builds and links from source that actually works with MariaDB. Maybe our cmake wizard @averysumner can elaborate a bit more on that.

maxonary · 2021-12-14T11:36:43Z

I can approve this script compiles on a RPI 4 8GB with Raspberry Pi OS 64-bit.

mixy1 · 2021-12-14T16:05:39Z

Hey so it's fine if I close this pull request and @jumpy-badger open's his?

@jumpy-badger is it finished?

Added commit guidelines to CONTRIBUTING.md to aid people in writing proper commits.

As part of the base enemy mech script its faction should be updated to 4 to make sure it's seen as an enemy by the client. The AgDarklingMech script has been deleted as its functionality was essentially that of BaseEnemyMech and thus no longer necessary.

Added issue templates to aid with the structural submission of issues.

When applied this commit updates the code style used when validating coin pickups.

…n tokens for 25 maelstrom infected bricks

Adds the ability for the buccaneer valiant to spawn a ship that rams enemies and smashes them. Next to a script that triggers the ship skill a few other changes had to be made: - Force movement behavior server side calculation and sync - The ship has no physics volume so the FindValidTargets for behaviors had to be altered to allow ControllablePhysics entities to find entities within their area. The "target_self" AOE flag has been used to replicate the old behavior.

This log was causing confusion and issues when in reality there was no problem present.

- Added debug logging - Created vLog, a root function for all log functions - Placed failed to load script log under this new LogDebug function - Updated included config functions

When applied this commit fixes the unix build of the previous dLogger PR. This commit also fixes backwards compatability with config files.

could be the cause of long-soak (hours long) sessions having CPU issues

mixy1 · 2021-12-14T16:23:45Z

Okay we're not merging this for sure. I don't know how I managed to screw up that commit history. @jumpy-badger you can take it from here.

jumpy-badger · 2021-12-14T16:33:09Z

I've got a few more changes to push to the branch. Will make a pull request once that's done

jumpy-badger · 2021-12-14T23:21:14Z

Opened a draft pr to get the ball rolling as the friends list is currently crashing the chatserver when someone accepts a request #231

Feel free to push any changes/fixes

MrPowerMac mentioned this pull request Dec 8, 2021

raknet fails to compile on arm64: "I can't tell what endian-ness to use for your architecture." #7

Closed

maxonary approved these changes Dec 14, 2021

View reviewed changes

mixy1 and others added 7 commits December 14, 2021 17:19

1 2 3 4 5

0a90100

fix formatting to match original.

a47ae08

remove conditional from else

55c92ed

Revert "separate AgSpaceStuff and AgShipShake"

48bb15c

Update CONTRIBUTING.md to include commit guidelines

14da296

Added commit guidelines to CONTRIBUTING.md to aid people in writing proper commits.

Add issue templates

006f215

Added issue templates to aid with the structural submission of issues.

Daystar1998 and others added 18 commits December 14, 2021 17:21

Fix spelling

a5adbc5

Fix spelling

e647b84

Add note to readme for troubleshooting tips with script editing

eee53c9

Minifig editing

e4610f5

patched coin exploit

b199659

Changes asked for by Wincent

447c603

Replace two casts with one

69ffe27

replace the other double cast

5911826

Update the code style

dc411ba

When applied this commit updates the code style used when validating coin pickups.

Update Entity.cpp

c335251

to improve (broken)

fdfa860

Potential solution

40ed136

increased the exchange rate of the nimbus station console to 5 factio…

58540e8

…n tokens for 25 maelstrom infected bricks

Add ship shake to not log about being missing

f0ada25

This log was causing confusion and issues when in reality there was no problem present.

Added a LogDebug

a515350

- Added debug logging - Created vLog, a root function for all log functions - Placed failed to load script log under this new LogDebug function - Updated included config functions

Fixes dlogger PR

8f624d7

When applied this commit fixes the unix build of the previous dLogger PR. This commit also fixes backwards compatability with config files.

fix undeleted dpEntity after enemy smashed

dfc0fdf

could be the cause of long-soak (hours long) sessions having CPU issues

mixy1 force-pushed the main branch from 2228424 to dfc0fdf Compare December 14, 2021 16:22

Merge branch 'DarkflameUniverse:main' into main

dc53788

mixy1 closed this Dec 14, 2021

sersorrel mentioned this pull request Dec 16, 2021

BUG: Mythran appearance/gminvis behaviour is buggy #246

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add aarch64 support to raknet and CMakesLists #111

Add aarch64 support to raknet and CMakesLists #111

mixy1 commented Dec 8, 2021 •

edited

Loading

codeshaunted commented Dec 8, 2021

mixy1 commented Dec 8, 2021

codeshaunted commented Dec 8, 2021

jumpy-badger commented Dec 8, 2021

mixy1 commented Dec 8, 2021

codeshaunted commented Dec 8, 2021

mixy1 commented Dec 8, 2021

jumpy-badger commented Dec 8, 2021

mixy1 commented Dec 8, 2021

mixy1 commented Dec 8, 2021

jumpy-badger commented Dec 8, 2021

codeshaunted commented Dec 9, 2021 •

edited

Loading

MickVermeulen commented Dec 10, 2021

mixy1 commented Dec 10, 2021

MickVermeulen commented Dec 10, 2021

mixy1 commented Dec 10, 2021 •

edited

Loading

MickVermeulen commented Dec 11, 2021

jumpy-badger commented Dec 11, 2021

MickVermeulen commented Dec 12, 2021

maxonary commented Dec 14, 2021 •

edited

Loading

mixy1 commented Dec 14, 2021

mixy1 commented Dec 14, 2021

jumpy-badger commented Dec 14, 2021

jumpy-badger commented Dec 14, 2021

Add aarch64 support to raknet and CMakesLists #111

Add aarch64 support to raknet and CMakesLists #111

Conversation

mixy1 commented Dec 8, 2021 • edited Loading

codeshaunted commented Dec 8, 2021

mixy1 commented Dec 8, 2021

codeshaunted commented Dec 8, 2021

jumpy-badger commented Dec 8, 2021

mixy1 commented Dec 8, 2021

codeshaunted commented Dec 8, 2021

mixy1 commented Dec 8, 2021

jumpy-badger commented Dec 8, 2021

mixy1 commented Dec 8, 2021

mixy1 commented Dec 8, 2021

jumpy-badger commented Dec 8, 2021

codeshaunted commented Dec 9, 2021 • edited Loading

MickVermeulen commented Dec 10, 2021

mixy1 commented Dec 10, 2021

MickVermeulen commented Dec 10, 2021

mixy1 commented Dec 10, 2021 • edited Loading

MickVermeulen commented Dec 11, 2021

jumpy-badger commented Dec 11, 2021

MickVermeulen commented Dec 12, 2021

maxonary commented Dec 14, 2021 • edited Loading

mixy1 commented Dec 14, 2021

mixy1 commented Dec 14, 2021

jumpy-badger commented Dec 14, 2021

jumpy-badger commented Dec 14, 2021

mixy1 commented Dec 8, 2021 •

edited

Loading

codeshaunted commented Dec 9, 2021 •

edited

Loading

mixy1 commented Dec 10, 2021 •

edited

Loading

maxonary commented Dec 14, 2021 •

edited

Loading