Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Ferdiand's Flowers glass blocks to sealable #2797

Merged
merged 1 commit into from
Jun 9, 2018
Merged

Added Ferdiand's Flowers glass blocks to sealable #2797

merged 1 commit into from
Jun 9, 2018

Conversation

keraldi
Copy link
Contributor

@keraldi keraldi commented Jun 9, 2018

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jun 9, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@justinrusso
Copy link
Member

justinrusso commented Jun 9, 2018 •
edited
Loading

Thanks for contributing! In 63fe185 @artdude543 mentions these were "broken". Adding him as a reviewer for his input.

artdude543
artdude543 approved these changes Jun 9, 2018
View reviewed changes
Copy link
Contributor

@artdude543 artdude543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is fine now. Caused by a typo in the original commit.

@justinrusso
Copy link
Member

Ah, I see now.

@justinrusso justinrusso merged commit ac31052 into DarkPacks:master Jun 9, 2018
@justinrusso justinrusso added this to the 3.0.9 milestone Jun 9, 2018
justinrusso added a commit that referenced this pull request Jun 9, 2018
@justinrusso
chore: Update changelog for #2797
79cf154
@justinrusso justinrusso modified the milestones: 3.0.9, 3.1.0 Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artdude543 artdude543 artdude543 approved these changes

@justinrusso justinrusso justinrusso approved these changes

Assignees
No one assigned
Labels
Category: Config Status: Completed Type: Enhancement
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@keraldi @CLAassistant @justinrusso @artdude543