-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autolock with pin code #338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need some help, I don't recall how, but I set this up but I don't remember my pin is there a default pin?
absolute bozo moment. no theres no default pin. the pin is whatever you have set lol. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, one problem with this change, it actually replaces auto keyboard lock with pin lock
When i have Pin set-up i can choose to lock with pin or not in top menu, but there it will just replace auto lock to use only pin if i have one,
It should be re-done in different way, for example we can add
bool autolock_with_pin;
into DesktopSettings
in applications/services/desktop/desktop_settings.h
And make UI selector in desktop settings app Auto Lock with pin: ON / OFF
And there we can just add
if (desktop->settings.autolock_with_pin){
if(desktop->settings.pin_code.length > 0) {
and we will use pin lock, in other case we will just call regular lock as it is done now
I can make that changes myself but later, tell me if you gonna make it optional as i described
Hm you're right, that's a good idea! Will do it myself, don't worry. |
Settings are saved as binary struct dump, so if we make any change to struct, we need to bump a version since it will not be compatible with older file in any case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I made small change, all details described in my last commit in its desc
All works as it should
What's new
Verification
Checklist (For Reviewer)