Fixes for morse code plugin #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed memory leak fixed noise after exiting the app fixed displaying characters after a long input
xMasterX
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Fixes for morse code plugin (Issues #248)
fixed memory leak
fixed noise after exiting the app (hold "back" when "ok" is pressed)
fixed displaying characters after a very long press
Verification
leave the application for 5-7 minutes, now it does not crash
check the absence of noise after holding down the back button when pressing the ok button
plugin continues to display characters after long pressing
Checklist (For Reviewer)