Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DAP025] False positive: SELECT INTO #79

Closed
dotTrench opened this issue Nov 16, 2023 · 2 comments · Fixed by #82
Closed

[DAP025] False positive: SELECT INTO #79

dotTrench opened this issue Nov 16, 2023 · 2 comments · Fixed by #82

Comments

@dotTrench
Copy link

dotTrench commented Nov 16, 2023 •
edited
Loading

Describe the bug
When using SqlConnection and selecting data from one table into another using ExecuteAsync a false DAP025 warning is triggered.

Dapper.Advisor: 1.0.10

To Reproduce

// DAP025: The command has a query that will be ignored
public static async Task SelectInto(SqlConnection connection) =>
    await connection.ExecuteAsync("SELECT [Test] INTO #MyTemporaryTable FROM MyTable");
@mgravell
Copy link
Member

Huh, I thought we were handling that one. Great catch, should be a one line fix, probably tomorrow morning.

mgravell added a commit that referenced this issue Nov 17, 2023
@mgravell
fix #79
b622698
@mgravell mgravell mentioned this issue Nov 17, 2023
Merged
mgravell added a commit that referenced this issue Nov 17, 2023
@mgravell
Assorted SQL analyzer fixes (#82)
94fcf0d 
* fix #79

* fix #80; add new rule 243 for invalid datepart expressions

* groundwork for aggregate

* fix #81; add new rule DAP244 for mixing aggregate and non-aggregate data
@mgravell
Copy link
Member

https://github.com/DapperLib/DapperAOT/releases/tag/1.0.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Assorted SQL analyzer fixes DapperLib/DapperAOT
2 participants
@mgravell @dotTrench