Update devcontainer with newer clang and IWYU. Ran IWYU

.devcontainer/Dockerfile

@@ -7,7 +7,21 @@ FROM mcr.microsoft.com/devcontainers/cpp:1-debian-12
 ENV CC=clang
 ENV CXX=clang++
 RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
-     && apt install lsb-release wget software-properties-common gnupg -y \
-     && bash -c "$(wget -O - https://apt.llvm.org/llvm.sh)"  \
-     && update-alternatives --install /usr/bin/cc cc /usr/bin/clang 100 \
-     && update-alternatives --install /usr/bin/c++ c++ /usr/bin/clang++ 100
+     && apt install lsb-release wget software-properties-common gnupg git -y \
+     && wget https://apt.llvm.org/llvm.sh  \
+     && chmod +x llvm.sh \
+     && ./llvm.sh 18 \
+     && apt install llvm-18-dev libclang-18-dev clang-18 -y \
+     && update-alternatives --install /usr/bin/cc cc /usr/bin/clang-18 100 \
+     && update-alternatives --install /usr/bin/c++ c++ /usr/bin/clang++-18 100 \
+     && update-alternatives --install /usr/bin/clang clang /usr/bin/clang-18 100 \
+     && update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-18 100
+
+RUN git clone https://github.com/include-what-you-use/include-what-you-use.git
+WORKDIR include-what-you-use
+RUN git checkout clang_18
+WORKDIR ..
+RUN mkdir build && cd build
+RUN cmake -G "Unix Makefiles" -DCMAKE_PREFIX_PATH=/usr/lib/llvm-18 ./include-what-you-use
+RUN make -j4
+RUN make install

CMakeLists.txt

@@ -214,7 +214,7 @@ if (ENABLE_IWYU)
 
     if (IWYU_PATH)
         set(CMAKE_CXX_INCLUDE_WHAT_YOU_USE "${IWYU_PATH}")
-        set_property(TARGET Zagreus PROPERTY CXX_INCLUDE_WHAT_YOU_USE "${IWYU_PATH}")
+        set_property(TARGET Zagreus PROPERTY CXX_INCLUDE_WHAT_YOU_USE "${IWYU_PATH};-Xiwyu;--error;-Xiwyu;--no_comments;-Xiwyu;--cxx17ns;-Xiwyu;--no_fwd_decls")
         message(STATUS "IWYU found and enabled: ${IWYU_PATH}")
     else ()
         message(WARNING "IWYU requested but not found. Please install IWYU or disable ENABLE_IWYU.")

src/bitboard.cpp

@@ -19,6 +19,7 @@ This file is part of Zagreus.
  */
 
 #include "bitboard.h"
+#include <array>
 #include "magics.h"
 
 namespace Zagreus {

src/bitboard.h

@@ -20,8 +20,8 @@
 
 #pragma once
 
+#include <cassert>
 #include <cstdint>
-#include <utility>
 
 #include "bitwise.h"
 #include "constants.h"

src/board.cpp

@@ -19,11 +19,9 @@
  */
 
 #include "board.h"
-
+#include <ctype.h>
 #include <iostream>
-#include <ostream>
 #include <string_view>
-
 #include "bitwise.h"
 #include "pcg_random.hpp"
 

src/board.h

@@ -21,17 +21,16 @@
 
 #pragma once
 
-#include <cstdint>
-#include <string_view>
-
 #include <algorithm>
 #include <array>
 #include <cassert>
-#include <utility>
-
+#include <cstdint>
+#include <string_view>
 #include "bitboard.h"
-#include "move.h"
+#include "bitwise.h"
 #include "constants.h"
+#include "move.h"
+#include "types.h"
 
 namespace Zagreus {
 /**

src/eval.cpp

@@ -19,8 +19,9 @@
  */
 
 #include "eval.h"
-
+#include "constants.h"
 #include "eval_features.h"
+#include "types.h"
 
 namespace Zagreus {
 /**

src/magics.cpp

@@ -19,10 +19,11 @@
  */
 
 #include "magics.h"
-
-#include <chrono>
+#include <bits/chrono.h>
+#include <stdio.h>
 #include <cstdint>
 #include <iostream>
+#include <limits>
 #include <random>
 
 // Code for magic generation https://www.chessprogramming.org/Looking_for_Magics

src/move.h

@@ -21,10 +21,11 @@
 
 #pragma once
 
+#include <cassert>
+#include <cstdint>
 #include <array>
-#include <iostream>
 #include <string>
-
+#include <string_view>
 #include "constants.h"
 #include "types.h"
 

src/move_gen.cpp

@@ -18,14 +18,16 @@
  along with Zagreus.  If not, see <https://www.gnu.org/licenses/>.
  */
 
-#include <array>
-
 #include "move_gen.h"
+#include <cassert>
+#include <array>
+#include <initializer_list>
+#include "bitboard.h"
 #include "bitwise.h"
 #include "board.h"
-#include "types.h"
-#include "bitboard.h"
+#include "constants.h"
 #include "move.h"
+#include "types.h"
 
 namespace Zagreus {
 

src/move_gen.h

@@ -22,13 +22,10 @@
 #pragma once
 
 #include <cstdint>
-
 #include "board.h"
 #include "move.h"
 #include "types.h"
 
-enum PieceColor : uint8_t;
-
 namespace Zagreus {
 enum GenerationType : uint8_t {
     ALL,

src/move_picker.h

@@ -21,10 +21,7 @@
 #pragma once
 
 #include <array>
-
-#include "constants.h"
 #include "move.h"
-#include "types.h"
 
 namespace Zagreus {
 // TODO: Implement efficient sorting by score, after implementing score.

src/perft.cpp

@@ -19,11 +19,13 @@
  */
 
 #include "perft.h"
-
+#include <cassert>
+#include <array>
 #include <iostream>
-
+#include <string>
 #include "move.h"
 #include "move_gen.h"
+#include "types.h"
 
 namespace Zagreus {
 /**

src/search.cpp

@@ -18,15 +18,15 @@
  along with Zagreus.  If not, see <https://www.gnu.org/licenses/>.
  */
 
-#include <limits>
-
 #include "search.h"
-
+#include <limits>
 #include "board.h"
+#include "constants.h"
 #include "eval.h"
 #include "move.h"
 #include "move_gen.h"
 #include "move_picker.h"
+#include "types.h"
 
 namespace Zagreus {
 Move search(Board& board) {

src/uci.cpp

@@ -18,19 +18,21 @@
  along with Zagreus.  If not, see <https://www.gnu.org/licenses/>.
  */
 
-#include <chrono>
+#include "uci.h"
+#include <bits/chrono.h>
+#include <stddef.h>
+#include <stdint.h>
 #include <algorithm>
+#include <cctype>
 #include <iostream>
 #include <sstream>
+#include <stdexcept>
 #include <string>
-#include <cctype>
 #include <thread>
-
-#include "magics.h"
-#include "uci.h"
-
-#include "board.h"
 #include "bitboard.h"
+#include "board.h"
+#include "magics.h"
+#include "move.h"
 #include "perft.h"
 
 namespace Zagreus {