Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change whitespace, indentation or line-breaks #68

Merged
merged 1 commit into from
May 21, 2024

Conversation

kronn
Copy link
Contributor

@kronn kronn commented May 21, 2024

I noticed a little trailing whitespace in the template. As this lands in every generated completion-script, I wanted to remove it at the source. Otherwise, it might lead to unneeded churn (when tooling removes it, but it gets added again), error-highlighting (linting, pre-commit-hooks, et al) and disk-space usage (depends on how many completetion you generate, of course).

This is a really unimportant change, yet I took the time to open this PR. So maybe there is even some emotional value in the ensuing calmness coming from fewer unneeded spaces copied into generated files?

@DannyBen
Copy link
Owner

This is a really unimportant change, yet I took the time to open this PR. So maybe there is even some emotional value in the ensuing calmness coming from fewer unneeded spaces copied into generated files?

Heh :) Absolutely. Important for the code and for its emotional value. Thanks.

After this is merged, I might add shfmt spec on top of the shellcheck spec.

@DannyBen DannyBen merged commit a0c3a62 into DannyBen:master May 21, 2024
7 checks passed
@kronn kronn deleted the remove-whitespace-in-template branch May 21, 2024 10:32
@DannyBen DannyBen mentioned this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants