-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve template #12
Improve template #12
Conversation
Thanks. Why is this better? |
Hey :)
|
Ok. What do we gain from this:
and more importantly, could this be NOT desired in some cases? |
The always complete thing |
I don't understand what that means. What behavior does it add exactly. Also this line:
breaks the tests. Specifically this test: completely/spec/completely/integration_spec.rb Lines 12 to 16 in 8819f56
The result is an empty array. Also tried defining the locals before the |
I think I found the problem. Need to source I will probably create a new PR with the fixed tests to supersede this one, but unless there is a good reason to keep thises |
I am closing this in favor of #13 - let's continue discussion there. |
No description provided.