Fix unwrapping of operator sections with placeholders #1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1682
This is pretty subtle:
replaceChilddoesn't preserve the aliasing in our grandparent'sbody. Because ofWrappernodes in this context, it doesn't work (easily) to put this check intoreplaceChild. I hope this is the only place we need to do this (where we replace the top level of an ampersand block), but plausibly there are other uses ofreplaceChildwith this issue.An alternative would be to remove ampersand block's
bodyproperties altogether, and just use the block's first expression. Plausibly, we can decide whether to unwrap even without theampersandBlockhint, checking for a single expression that uses the argument once. Then we could unwrap non-shorthand arrow functions too. Maybe an approach to try in the future.