Merge pull request #1678 from DanielXMoore/pipe-new-fix

Fix pipe into certain `new` expressions
DanielXMoore · Jan 5, 2025 · d64686f · d64686f
2 parents aa8b8c1 + 5435a9a
commit d64686f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/source/parser/pipe.civet b/source/parser/pipe.civet
@@ -73,9 +73,8 @@ function constructInvocation(fn: ExprWithComments, arg: ASTNode!)
   if lhs.type is "NewExpression"
     { expression } .= lhs
     expression = {
-      ...expression
       type: "CallExpression"
-      children: [ ...expression.children, call ]
+      children: [ expression, call ]
     }
     {
       ...lhs

diff --git a/test/pipe.civet b/test/pipe.civet
@@ -355,6 +355,14 @@ describe "pipe", ->
     new Foo(x)(x)
   """
 
+  throws """
+    pipe to invalid new
+    ---
+    x |> new .
+    ---
+    ParseErrors: unknown:1:10 Partial placeholder . outside of call expression
+  """
+
   testCase """
     pipe from new
     ---