Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segmentation fault due to modification of timeline while iterating #65

Closed
DanielSWolf opened this issue Feb 10, 2019 · 1 comment
Closed

Segmentation fault due to modification of timeline while iterating #65

DanielSWolf opened this issue Feb 10, 2019 · 1 comment
Labels
bug

Comments

@DanielSWolf
Copy link
Owner

In voiceActivityDetection.cpp, the activity timeline is modified while being iterated. This results in undefined behavior. On Windows, the code seems to work; on OS X, it results in a segmentation fault.

This may be the same bug @RankoR observed in #62.
DanielSWolf added a commit that referenced this issue Feb 10, 2019
@DanielSWolf
Clone timeline to prevent modification during iteration
6c62318 
Fixes #65
@DanielSWolf DanielSWolf mentioned this issue Feb 10, 2019
Merged
DanielSWolf added a commit that referenced this issue Feb 10, 2019
@DanielSWolf
Merge pull request #66 from DanielSWolf/bugfix/#65-modification-durin…
f3b9017 
…g-iteration

Clone timeline to prevent modification during iteration
@RankoR
Copy link

RankoR commented Feb 10, 2019

Thanks. I will test it and report if bug is still there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RankoR @DanielSWolf