Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SplitSummaryAndDocstringFormatter #69

Merged
merged 4 commits into from
Mar 13, 2022
Merged

Improve SplitSummaryAndDocstringFormatter #69

merged 4 commits into from
Mar 13, 2022

Conversation

DanielNoord
Copy link
Owner

I have tested this (partially) on pylint and with max-summary-lines=2 I think we can turn this on for pylint.

I'd like to do that first and then release 0.6.0 with the wrapping of lines. That should make the diff somewhat more manageable.

@DanielNoord DanielNoord added the enhancement New feature or request label Mar 13, 2022
@DanielNoord DanielNoord added this to the 0.5.0 milestone Mar 13, 2022
@coveralls
Copy link

coveralls commented Mar 13, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1976036172

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 1932515412: 0.0%
Covered Lines: 395
Relevant Lines: 395
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas reviewed Mar 13, 2022
View reviewed changes
Copy link
Collaborator

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good ! Looking forward to pydocstringformatter being upgradeable with pre-commit automatically 😄

tests/data/format/summary_splitter/dots.py.out Show resolved Hide resolved
DanielNoord and others added 2 commits March 13, 2022 11:11
@DanielNoord
Copy link
Owner Author

Added handling of etc..

I wonder how this will interact with the automatic period adder for pylint. But that should be fixable in 0.6.0.

@DanielNoord DanielNoord merged commit 26c6f1b into main Mar 13, 2022
@DanielNoord DanielNoord deleted the splitter branch March 13, 2022 10:19
DanielNoord added a commit that referenced this pull request Mar 23, 2022
@DanielNoord @Pierre-Sassoulas
Improve SplitSummaryAndDocstringFormatter (#69)
aa342f6 
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielNoord @coveralls @Pierre-Sassoulas