Add SplitSummaryAndDocstringFormatter and update testutils
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1780549797
💛 - Coveralls |
|
Running over |
Pierre-Sassoulas
approved these changes
Jan 9, 2022
There was a problem hiding this comment.
LGTM but I think we could merge #32 before so it simplify the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testutils update is very basic.
I think we would want
pyproject.tomlsupport as well, but for now just adding args in an.argsfile and separating them by spaces is good enough. Just make sure that when we start adding more and more of such files we start considering rewriting them so that we're not stuck with 100+.argsfiles when we finally get to it.I have made this optional as I think this might be a bit opinionated and wonder the impact on projects like
pylint.Closes #25