Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug where empty summaries fail with index error #163

Merged
merged 3 commits into from
Sep 12, 2022

Conversation

jspaezp
Copy link
Contributor

@jspaezp jspaezp commented Sep 10, 2022

Discussed in the second section of:

Closes partially and therefore refs #160

@github-actions

This comment has been minimized.

@codecov
Copy link

codecov bot commented Sep 10, 2022

Codecov Report

Merging #163 (abbfbee) into main (60a82b3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #163   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          589       590    +1     
=========================================
+ Hits           589       590    +1     
Impacted Files Coverage Δ
...cstringformatter/_formatting/formatters_default.py 100.00% <100.00%> (ø)

@DanielNoord DanielNoord linked an issue Sep 12, 2022 that may be closed by this pull request
@github-actions

This comment has been minimized.

@DanielNoord DanielNoord enabled auto-merge (squash) September 12, 2022 07:34
@github-actions
Copy link

According to the primer, this change has no effect on the checked open source code. 🤖🎉

@DanielNoord DanielNoord merged commit 5a58ed1 into DanielNoord:main Sep 12, 2022
@jspaezp jspaezp deleted the bugfix/empty_summary branch September 12, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug, Unhandled case when a section is empty
3 participants