Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

request is deprecated #7

Closed
adamhassel opened this issue Dec 21, 2021 · 2 comments
Closed

request is deprecated #7

adamhassel opened this issue Dec 21, 2021 · 2 comments

Comments

@adamhassel
Copy link

Describe the bug

The request library is deprecated and no longer supported.

Additional context

request/request#3142
DanielHabenicht added a commit that referenced this issue Jan 9, 2022
@DanielHabenicht
fix: use node-fetch instead of request
392350d 
fixes `request` is deprecated #7

BREAKING CHANGE: use `fetchOptions` instead of `request` in you config
DanielHabenicht added a commit that referenced this issue Jan 9, 2022
@DanielHabenicht
fix: use node-fetch instead of request
3da5189 
fixes `request` is deprecated #7

BREAKING CHANGE: use `fetchOptions` instead of `request` in you config
DanielHabenicht added a commit that referenced this issue Jan 9, 2022
@DanielHabenicht
fix: use node-fetch instead of request
75cd82f 
fixes `request` is deprecated #7

BREAKING CHANGE: use `fetchOptions` instead of `request` in you config
github-actions bot pushed a commit that referenced this issue Jan 9, 2022
@semantic-release-bot
chore(release): 2.0.0 [skip ci]
e27d9cd 
# [2.0.0](v1.1.4...v2.0.0) (2022-01-09)

### Bug Fixes

* Rename Notifications ([869e182](869e182))
* use node-fetch instead of request ([75cd82f](75cd82f)), closes [#7](#7)

### BREAKING CHANGES

* use `fetchOptions` instead of `request` in you config
* rename notifications

to better resemble that they could also be POST or other requests.

MMM_JSON_GET_REQUEST > MMM_JSON_REQUEST
MMM_JSON_GET_RESPONSE > MMM_JSON_RESPONSE
@DanielHabenicht
Copy link
Owner

fixed in #8

@DanielHabenicht
Copy link
Owner

Thanks for poking me about it. It was already outdated when I create the module but I couldn't find a good alternative at that point in time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamhassel @DanielHabenicht