Add recaptcha script loader on beforeMount hook #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a script to add a <script> tag reCAPTCHA that loads the reCAPTCHA script from remote. It is configurable from props, and currently it is opt-in (loadRecaptchaScript must be set to true).
DanSnow
requested changes
Jun 19, 2019
|
Thanks for the PR. Actually I have already added this feature at another branch. But this approach seem simpler and doesn't introduce a breaking change. I think I'll use this one. |
DanSnow
reviewed
Jun 19, 2019
|
Also please also update the README to describe the new props |
Add information about loadRecaptchaScript
DanSnow
approved these changes
Jun 21, 2019
|
🎉 |
|
Might need to add a setting for other parameters you use in the URL for loading recaptcha, such as language (hl)? |
|
@Nettsentrisk I think the user can manually setup the API's url, so it's not necessary |
|
Isn't there only a setting for the hostname, not the entire URL? The recaptcha API URL takes up to 3 URL parameters, so it should be possible to use all of those through this to be flexible enough. Perhaps it would be easier if the user can provide the entire URL if they want/need to. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a script to add a <script> tag reCAPTCHA that loads the reCAPTCHA script from remote.
It is configurable from props, and currently it is opt-in (loadRecaptchaScript must be set to true).