Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit:schema:update does not take into account default table options #221

Closed
oleg-andreyev opened this issue Sep 25, 2024 · 0 comments · Fixed by #232
Closed

audit:schema:update does not take into account default table options #221

oleg-andreyev opened this issue Sep 25, 2024 · 0 comments · Fixed by #232
Labels
bug Something isn't working

Comments

@oleg-andreyev
Copy link
Contributor

oleg-andreyev commented Sep 25, 2024 •
edited
Loading

Q A
auditor version 3.0.1
PHP version 8.3.x
Database MySQL

Summary

Running ./bin/console audit:schema:update --dump-sql
Return ALTER that does not change anything, problem is doctrine/DoctrineBundle#1468 (comment)

Database return charset and collation, but when building schema does not know about this options, even if they are defined on connection level.

\DH\Auditor\Provider\Doctrine\Persistence\Helper\SchemaHelper::getAuditTableColumns

Current behavior

ALTER that does not make sense.

image
image

How to reproduce

Expected behavior

inherit default_table_options from config
@oleg-andreyev oleg-andreyev added the bug Something isn't working label Sep 25, 2024
oleg-andreyev added a commit to oleg-andreyev/auditor that referenced this issue Nov 11, 2024
@oleg-andreyev
fixes DamienHarper#221
1647979 
Signed-off-by: Oleg Andreyev <oleg@andreyev.lv>
@oleg-andreyev oleg-andreyev mentioned this issue Nov 11, 2024
Merged
DamienHarper pushed a commit that referenced this issue Nov 11, 2024
@oleg-andreyev
fixes #221 (#232)
2fd99aa 
Signed-off-by: Oleg Andreyev <oleg@andreyev.lv>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inherit defaultTableOptions oleg-andreyev/auditor
1 participant
@oleg-andreyev