Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(practices): add dependsOn in related practices #38

Merged
merged 1 commit into from
Aug 20, 2019
Merged

hotfix(practices): add dependsOn in related practices #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@
"glob": "^7.1.4",
"inversify": "^5.0.1",
"lodash": "^4.17.15",
"node-filter-async": "^1.1.3",
"memfs": "^2.15.5",
"node-filter-async": "^1.1.3",
"npm-check-updates": "^3.1.20",
"oclif": "^1.13.5",
"reflect-metadata": "^0.1.13",
Expand Down
1 change: 1 addition & 0 deletions src/practices/JavaScript/JsGitignoreCorrectlySetPractice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import { PracticeContext } from '../../contexts/practice/PracticeContext';
suggestion: 'Scripts in the .gitignore set as usual.',
reportOnlyOnce: true,
url: 'https://github.com/github/gitignore/blob/master/Node.gitignore',
dependsOn: { practicing: ['LanguageIndependent.GitignoreIsPresent'] },
})
export class JsGitignoreCorrectlySetPractice implements IPractice {
async isApplicable(ctx: PracticeContext): Promise<boolean> {
Expand Down
1 change: 1 addition & 0 deletions src/practices/JavaScript/JsPackageJsonConfigurationSetCorrectlyPractice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import { PracticeContext } from '../../contexts/practice/PracticeContext';
'Use right configuration to automate repetitive tasks. Use build to automate the build process, lint for linting your code, test for testing and start to run your project.',
reportOnlyOnce: true,
url: 'https://docs.npmjs.com/files/package.json',
dependsOn: { practicing: ['Javascript.PackageManagementUsed'] },
})
export class JsPackageJsonConfigurationSetCorrectlyPractice implements IPractice {
async isApplicable(ctx: PracticeContext): Promise<boolean> {
Expand Down