-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(practices): display properly correct commit messages practice det… #198
Conversation
DX Scanner Reporthttps://github.com/DXHeroes/dx-scanner
|
Name | New | Current |
---|---|---|
ts-node | 8.6.2 | 8.6.1 |
@types/node | 13.1.6 | 12.12.24 |
semantic-release | 16.0.1 | 15.14.0 |
@typescript-eslint/eslint-plugin | 2.16.0 | 2.15.0 |
@typescript-eslint/parser | 2.16.0 | 2.15.0 |
Impact changed from high to medium.
ESLint Without Errors
Use the ESLint correctly. You have some errors. https://eslint.org/
🔔 Improvements with minor impact
Write Commit Messages by Convention
https://www.conventionalcommits.org/
Commit Message | Problems |
---|---|
Add security vulnerabilities practice | subject may not be empty; type may not be empty |
Update src/services/git/MOCKS/bitbucketServiceMockFolder/getPullCommits.ts | header must not be longer than 72 characters, current length is 78; subject may not be empty; type may not be empty |
Update src/services/git/MOCKS/bitbucketServiceMockFolder/getRepoCommits.ts | header must not be longer than 72 characters, current length is 78; subject may not be empty; type may not be empty |
Update Dependencies of Major Level
Keep the dependencies updated to have all possible features. Use, for example, npm-check-updates. https://github.com/tjunnone/npm-check-updates
Name | New | Current |
---|---|---|
@semantic-release/git | 8.0.0 | 7.0.18 |
@types/node | 13.1.6 | 12.12.24 |
semantic-release | 16.0.1 | 15.14.0 |
Use a JS Logging Library
Use a logging library to avoid errors and even cyber attacks. The most widely used logging library in the JavaScript community is Winston. https://www.npmjs.com/package/winston/
Implementation is not adoption.
We can help you with both. :-)
dxheroes.io
Found a bug? Please report.
56d62cf
to
77d28f7
Compare
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
+ Coverage 82.99% 84.61% +1.61%
==========================================
Files 162 162
Lines 3505 3509 +4
Branches 543 549 +6
==========================================
+ Hits 2909 2969 +60
+ Misses 596 540 -56
|
64476c0
to
b96e18d
Compare
b96e18d
to
8b4e489
Compare
e667441
to
e4fa36e
Compare
- do not analyse all commits
e4fa36e
to
343619a
Compare
f212797
to
4e566e9
Compare
…vice # Conflicts: # src/services/git/GitHubService.ts
src/practices/LanguageIndependent/CorrectCommitMessagesPractice.spec.ts
Outdated
Show resolved
Hide resolved
src/practices/LanguageIndependent/CorrectCommitMessagesPractice.spec.ts
Outdated
Show resolved
Hide resolved
Co-Authored-By: Adela Homolova <53510747+adelkahomolova@users.noreply.github.com>
Co-Authored-By: Adela Homolova <53510747+adelkahomolova@users.noreply.github.com>
1fa0952
to
70f4fa0
Compare
70f4fa0
to
6492959
Compare
🎉 This PR is included in version 1.33.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
…ailed data