Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(practices): display properly correct commit messages practice det… #198

Merged
merged 18 commits into from
Jan 14, 2020

Conversation

prokopsimek
Copy link
Member

…ailed data

@prokopsimek prokopsimek self-assigned this Jan 9, 2020
@prokopsimek
Copy link
Member Author

prokopsimek commented Jan 9, 2020

DX Scanner Report DXScanner.io

https://github.com/DXHeroes/dx-scanner

⚠️ Improvements with medium impact

Solve Issues Continuously

Do not have an open Issues more than 60 days. Solve Issues continuously. https://hackernoon.com/45-github-issues-dos-and-donts-dfec9ab4b612

Update Dependencies of Minor and Patch Level

Keep the dependencies updated to eliminate security concerns and compatibility issues. Use, for example, npm-check-updates. https://github.com/tjunnone/npm-check-updates

Name New Current
ts-node 8.6.2 8.6.1
@types/node 13.1.6 12.12.24
semantic-release 16.0.1 15.14.0
@typescript-eslint/eslint-plugin 2.16.0 2.15.0
@typescript-eslint/parser 2.16.0 2.15.0

Impact changed from high to medium.

ESLint Without Errors

Use the ESLint correctly. You have some errors. https://eslint.org/

🔔 Improvements with minor impact

Write Commit Messages by Convention

https://www.conventionalcommits.org/

Commit Message Problems
Add security vulnerabilities practice subject may not be empty; type may not be empty
Update src/services/git/MOCKS/bitbucketServiceMockFolder/getPullCommits.ts header must not be longer than 72 characters, current length is 78; subject may not be empty; type may not be empty
Update src/services/git/MOCKS/bitbucketServiceMockFolder/getRepoCommits.ts header must not be longer than 72 characters, current length is 78; subject may not be empty; type may not be empty
Update Dependencies of Major Level

Keep the dependencies updated to have all possible features. Use, for example, npm-check-updates. https://github.com/tjunnone/npm-check-updates

Name New Current
@semantic-release/git 8.0.0 7.0.18
@types/node 13.1.6 12.12.24
semantic-release 16.0.1 15.14.0
Use a JS Logging Library

Use a logging library to avoid errors and even cyber attacks. The most widely used logging library in the JavaScript community is Winston. https://www.npmjs.com/package/winston/

🔥 Evaluation of these practices failed - Break down large pull requests into smaller ones

Implementation is not adoption.
We can help you with both. :-)
dxheroes.io

Found a bug? Please report.

@prokopsimek prokopsimek force-pushed the hotfix/correct-commit-messages branch from 56d62cf to 77d28f7 Compare January 9, 2020 14:50
@codecov-io
Copy link

codecov-io commented Jan 9, 2020

Codecov Report

Merging #198 into master will increase coverage by 1.61%.
The diff coverage is 83.72%.

@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
+ Coverage   82.99%   84.61%   +1.61%     
==========================================
  Files         162      162              
  Lines        3505     3509       +4     
  Branches      543      549       +6     
==========================================
+ Hits         2909     2969      +60     
+ Misses        596      540      -56
Impacted Files Coverage Δ
src/inspectors/ICollaborationInspector.ts 100% <ø> (ø) ⬆️
...viceMockFolder/getPullFilesServiceResponse.mock.ts 100% <ø> (ø) ⬆️
src/services/git/IVCSService.ts 100% <ø> (ø) ⬆️
...eMockFolder/getContributorsServiceResponse.mock.ts 100% <ø> (ø) ⬆️
...MockFolder/getIssueCommentsServiceResponse.mock.ts 100% <ø> (ø) ⬆️
src/reporters/CIReporter.ts 29.11% <0%> (-0.76%) ⬇️
...nguageIndependent/CorrectCommitMessagesPractice.ts 96.15% <100%> (ø) ⬆️
.../practices/LanguageIndependent/DoesPullRequests.ts 100% <100%> (+48.14%) ⬆️
src/practices/index.ts 100% <100%> (ø) ⬆️
src/inspectors/IssueTrackingInspector.ts 100% <100%> (ø) ⬆️
... and 13 more

@prokopsimek prokopsimek force-pushed the hotfix/correct-commit-messages branch 4 times, most recently from 64476c0 to b96e18d Compare January 10, 2020 07:50
@prokopsimek prokopsimek force-pushed the hotfix/correct-commit-messages branch from b96e18d to 8b4e489 Compare January 10, 2020 08:18
@prokopsimek prokopsimek force-pushed the hotfix/correct-commit-messages branch 2 times, most recently from e667441 to e4fa36e Compare January 10, 2020 16:00
@prokopsimek prokopsimek force-pushed the hotfix/correct-commit-messages branch from e4fa36e to 343619a Compare January 10, 2020 16:04
@prokopsimek prokopsimek force-pushed the hotfix/correct-commit-messages branch from f212797 to 4e566e9 Compare January 14, 2020 12:23
prokopsimek and others added 2 commits January 14, 2020 14:41
Co-Authored-By: Adela Homolova <53510747+adelkahomolova@users.noreply.github.com>
Co-Authored-By: Adela Homolova <53510747+adelkahomolova@users.noreply.github.com>
@prokopsimek prokopsimek force-pushed the hotfix/correct-commit-messages branch from 1fa0952 to 70f4fa0 Compare January 14, 2020 13:52
@prokopsimek prokopsimek force-pushed the hotfix/correct-commit-messages branch from 70f4fa0 to 6492959 Compare January 14, 2020 13:55
@prokopsimek prokopsimek merged commit d04601f into master Jan 14, 2020
@prokopsimek prokopsimek deleted the hotfix/correct-commit-messages branch January 14, 2020 14:09
@prokopsimek
Copy link
Member Author

🎉 This PR is included in version 1.33.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants